From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v10 5/8] security: keys: trusted: Make sealed key properly interoperable
Date: Thu, 18 Jun 2020 02:46:41 +0300 [thread overview]
Message-ID: <20200617234641.GL62794@linux.intel.com> (raw)
In-Reply-To: <20200616160229.8018-6-James.Bottomley@HansenPartnership.com>
On Tue, Jun 16, 2020 at 09:02:26AM -0700, James Bottomley wrote:
> The current implementation appends a migratable flag to the end of a
> key, meaning the format isn't exactly interoperable because the using
> party needs to know to strip this extra byte. However, all other
> consumers of TPM sealed blobs expect the unseal to return exactly the
> key. Since TPM2 keys have a key property flag that corresponds to
> migratable, use that flag instead and make the actual key the only
> sealed quantity. This is secure because the key properties are bound
> to a hash in the private part, so if they're altered the key won't
> load.
>
> Backwards compatibility is implemented by detecting whether we're
> loading a new format key or not and correctly setting migratable from
> the last byte of old format keys.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2020-06-17 23:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 16:02 [PATCH v10 0/8] TPM 2.0 trusted keys with attached policy James Bottomley
2020-06-16 16:02 ` [PATCH v10 1/8] lib: add ASN.1 encoder James Bottomley
2020-06-16 16:02 ` [PATCH v10 2/8] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-06-17 21:42 ` Jerry Snitselaar
2020-06-18 0:25 ` James Bottomley
2020-06-18 7:14 ` Jarkko Sakkinen
2020-06-18 19:22 ` James Bottomley
2020-06-22 22:04 ` Jarkko Sakkinen
2020-06-16 16:02 ` [PATCH v10 3/8] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-06-16 16:02 ` [PATCH v10 4/8] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-06-16 16:02 ` [PATCH v10 5/8] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2020-06-17 23:46 ` Jarkko Sakkinen [this message]
2020-06-16 16:02 ` [PATCH v10 6/8] security: keys: trusted: add PCR policy to TPM2 keys James Bottomley
2020-06-17 23:44 ` Jarkko Sakkinen
2020-06-16 16:02 ` [PATCH v10 7/8] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2020-06-17 23:42 ` Jarkko Sakkinen
2020-06-18 0:27 ` James Bottomley
2020-06-18 7:12 ` Jarkko Sakkinen
2020-06-18 19:45 ` James Bottomley
2020-06-23 0:46 ` Jarkko Sakkinen
2020-06-16 16:02 ` [PATCH v10 8/8] security: keys: trusted: implement counter/timer policy James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617234641.GL62794@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).