From: Petr Vorel <pvorel@suse.cz>
To: linux-integrity@vger.kernel.org
Cc: Petr Vorel <pvorel@suse.cz>, Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: [PATCH ima-evm-utils 2/3] Don't run tsspcrread on systems without TPM
Date: Thu, 18 Jun 2020 20:50:37 +0200 [thread overview]
Message-ID: <20200618185038.21837-1-pvorel@suse.cz> (raw)
as we don't have any algorithm:
./src/evmctl ima_boot_aggregate
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `tsspcrread -halg (null) -ha 0 -ns 2> /dev/null'
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `tsspcrread -halg (null) -ha 0 -ns 2> /dev/null'
errno: No such file or directory (2)
Now it just prints:
errno: No such file or directory (2)
Fixes: dc00c92 ("ima-evm-utils: calculate the per TPM bank
boot_aggregate")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi Mimi,
not really sure if this is a best place to handle the problem.
Kind regards,
Petr
src/evmctl.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/evmctl.c b/src/evmctl.c
index 94ec56b..03eeb6e 100644
--- a/src/evmctl.c
+++ b/src/evmctl.c
@@ -1796,6 +1796,12 @@ static int read_tpm_banks(int num_banks, struct tpm_bank_info *bank)
for (i = 0; i < num_banks; i++) {
err = 0;
for (j = 0; j < NUM_PCRS && !err; j++) {
+ if (!bank[i].algo_name) {
+ log_debug("No algo_name for PCR: %d\n", i);
+ bank[i].supported = 0;
+ continue;
+ }
+
err = tpm2_pcr_read(bank[i].algo_name, j,
bank[i].pcr[j], bank[i].digest_size,
&errmsg);
--
2.27.0
next reply other threads:[~2020-06-18 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 18:50 Petr Vorel [this message]
2020-06-18 18:50 ` [RFC PATCH ima-evm-utils 3/3] logging: Print also LOG_INFO messages Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618185038.21837-1-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).