Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: "Wiseman, Monty (GE Research, US)" <monty.wiseman@ge.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: Re: [PATCH 3/8] oid_registry: Add TCG defined OIDS for TPM keys
Date: Fri, 19 Jun 2020 15:50:24 -0700
Message-ID: <20200619225024.kmhdqe25cmgaq5e4@cantor> (raw)
In-Reply-To: <26ED11907FC0F446BB0296B5357EEF0E316CDBB0@CINMBCNA02.e2k.ad.ge.com>

On Fri Jun 19 20, Wiseman, Monty (GE Research, US) wrote:
>James,
>
>> -----Original Message-----
>> From: David Woodhouse <dwmw2@infradead.org>
>> Sent: December 9, 2019 03:56 AM
>> To: James Bottomley <James.Bottomley@HansenPartnership.com>; linux-
>> integrity@vger.kernel.org; Wiseman, Monty (GE Global Research, US)
>> <monty.wiseman@ge.com>
>> Cc: Mimi Zohar <zohar@linux.ibm.com>; Jarkko Sakkinen
>> <jarkko.sakkinen@linux.intel.com>
>> Subject: EXT: Re: [PATCH 3/8] oid_registry: Add TCG defined OIDS for TPM
>> keys
>>
>> On Sat, 2019-12-07 at 21:09 -0800, James Bottomley wrote:
>> > The TCG has defined an OID prefix "2.23.133.10.1" for the various TPM
>> > key uses.  We've defined three of the available numbers:
>> >
>> > 2.23.133.10.1.3 TPM Loadable key.  This is an asymmetric key (Usually
>> > 		RSA2048 or Elliptic Curve) which can be imported by a
>> > 		TPM2_Load() operation.
>> >
>> > 2.23.133.10.1.4 TPM Importable Key.  This is an asymmetric key (Usually
>> > 		RSA2048 or Elliptic Curve) which can be imported by a
>> > 		TPM2_Import() operation.
>> >
>> > Both loadable and importable keys are specific to a given TPM, the
>> > difference is that a loadable key is wrapped with the symmetric
>> > secret, so must have been created by the TPM itself.  An importable
>> > key is wrapped with a DH shared secret, and may be created without
>> > access to the TPM provided you know the public part of the parent key.
>> >
>> > 2.23.133.10.1.5 TPM Sealed Data.  This is a set of data (up to 128
>> > 		bytes) which is sealed by the TPM.  It usually
>> > 		represents a symmetric key and must be unsealed before
>> > 		use.
>>
>> Do we still not have an official reference for these that you can
>> provide in the commit or the file itself?
>>
>> It would be very nice to have something more than a verbal assurance
>> that they're in Monty's spreadsheet.
>>
>>
>> > Signed-off-by: James Bottomley
>> <James.Bottomley@HansenPartnership.com>
>> > ---
>> >  include/linux/oid_registry.h | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/include/linux/oid_registry.h b/include/linux/oid_registry.h
>> > index 657d6bf2c064..a4cee888f9b0 100644
>> > --- a/include/linux/oid_registry.h
>> > +++ b/include/linux/oid_registry.h
>> > @@ -107,6 +107,11 @@ enum OID {
>> >  	OID_gostTC26Sign512B,		/* 1.2.643.7.1.2.1.2.2 */
>> >  	OID_gostTC26Sign512C,		/* 1.2.643.7.1.2.1.2.3 */
>> >
>> > +	/* TCG defined OIDS for TPM based keys */
>> > +	OID_TPMLoadableKey,		/* 2.23.133.10.1.3 */
>> > +	OID_TPMImporableKey,		/* 2.23.133.10.1.4 */
>> > +	OID_TPMSealedData,		/* 2.23.133.10.1.5 */
>> > +
>> >  	OID__NR
>> >  };
>> >
>Bring back an old thread.  We are finally getting the TCG OID registry ready
>to publish and wanted to verifier the OIDs you requested and we assigned
>above.
>
>I can find 2.23.133.10.1.3 TPM Loadable key in the tpm2-tss-engine project.
>
>I do not see this one, nor the others list above in the kernel source. Did
>these ever
>get used? If so, where and can you provide a use case for a relying party?
>
>Also, I have in my local spreadsheet the following which I believe were just
>drafts and never assigned. Please confirm.
>2.23.133.10.1.1.2
>Secondary Identifier: tcg-wellKnownAuthValue
>
>This in intended to be bitmap of well-known authValues. This is not intended
>to contain an actual authValue. For example. Bit 1 means and authValue of
>hashsize all zeros, Bit 2 means an authValue of hashsize all NULLs, etc.
>[Note: Bit 1 is lsb in this notation]
>
>2.23.133.10.1.1.3
>No secondary identifier or description
>
>2.23.133.10.1.1.4
>No secondary identifier or description
>
>
>Monty Wiseman
>Principal Engineer, Security Architecture
>Controls & Optimization

Hi Monty,

The patchset is still being reviewed and discussed:

https://lore.kernel.org/linux-integrity/20200616160229.8018-3-James.Bottomley@HansenPartnership.com/


  reply index

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-08  5:06 [PATCH 0/8] Fix TPM 2.0 trusted keys James Bottomley
2019-12-08  5:07 ` [PATCH 1/8] security: keys: trusted: flush the key handle after use James Bottomley
2019-12-09  8:31   ` David Woodhouse
2019-12-09 15:38     ` James Bottomley
2019-12-08  5:08 ` [PATCH 2/8] lib: add asn.1 encoder James Bottomley
2019-12-09  8:50   ` David Woodhouse
2019-12-09 15:46     ` James Bottomley
2019-12-09 22:05   ` Matthew Garrett
2019-12-09 22:43     ` James Bottomley
2019-12-08  5:09 ` [PATCH 3/8] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2019-12-09  8:55   ` David Woodhouse
2019-12-09 16:21     ` James Bottomley
2020-06-19 20:45     ` Wiseman, Monty (GE Research, US)
2020-06-19 22:50       ` Jerry Snitselaar [this message]
2020-06-20 15:36       ` James Bottomley
2020-06-23  1:17       ` Jarkko Sakkinen
2019-12-08  5:10 ` [PATCH 4/8] security: keys: trusted: use ASN.1 tpm2 key format for the blobs James Bottomley
2019-12-09 10:04   ` David Woodhouse
2019-12-09 16:31     ` James Bottomley
2019-12-08  5:11 ` [PATCH 5/8] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2019-12-09 10:09   ` David Woodhouse
2019-12-09 17:23     ` James Bottomley
2019-12-08  5:12 ` [PATCH 6/8] security: keys: trusted: add PCR policy to TPM2 keys James Bottomley
2019-12-09 10:18   ` David Woodhouse
2019-12-09 18:03     ` James Bottomley
2019-12-09 18:44       ` David Woodhouse
2019-12-09 19:11         ` James Bottomley
2019-12-25 17:08           ` Ken Goldman
2019-12-08  5:13 ` [PATCH 7/8] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2019-12-08  5:14 ` [PATCH 8/8] security: keys: trusted: implement counter/timer policy James Bottomley
2019-12-09 20:20 ` [PATCH 0/8] Fix TPM 2.0 trusted keys Jarkko Sakkinen
2019-12-09 20:57   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619225024.kmhdqe25cmgaq5e4@cantor \
    --to=jsnitsel@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=dwmw2@infradead.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=monty.wiseman@ge.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git