From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Nicolas Boichat <drinkcat@chromium.org>,
Andrey Pronin <apronin@chromium.org>,
Stephen Boyd <swboyd@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_spi: Prefer async probe
Date: Tue, 23 Jun 2020 04:36:14 +0300 [thread overview]
Message-ID: <20200623013614.GJ28795@linux.intel.com> (raw)
In-Reply-To: <20200619141958.1.I58d549fded1fd2299543ede6a103fe2bb94c805d@changeid>
On Fri, Jun 19, 2020 at 02:20:01PM -0700, Douglas Anderson wrote:
> On a Chromebook I'm working on I noticed a big (~1 second) delay
> during bootup where nothing was happening. Right around this big
> delay there were messages about the TPM:
>
> [ 2.311352] tpm_tis_spi spi0.0: TPM ready IRQ confirmed on attempt 2
> [ 3.332790] tpm_tis_spi spi0.0: Cr50 firmware version: ...
>
> I put a few printouts in and saw that tpm_tis_spi_init() (specifically
> tpm_chip_register() in that function) was taking the lion's share of
> this time, though ~115 ms of the time was in cr50_print_fw_version().
>
> Let's make a one-line change to prefer async probe for tpm_tis_spi.
> There's no reason we need to block other drivers from probing while we
> load.
>
> NOTES:
> * It's possible that other hardware runs through the init sequence
> faster than Cr50 and this isn't such a big problem for them.
> However, even if they are faster they are still doing _some_
> transfers over a SPI bus so this should benefit everyone even if to
> a lesser extent.
> * It's possible that there are extra delays in the code that could be
> optimized out. I didn't dig since once I enabled async probe they
> no longer impacted me.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/char/tpm/tpm_tis_spi_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> index d96755935529..422766445373 100644
> --- a/drivers/char/tpm/tpm_tis_spi_main.c
> +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> @@ -288,6 +288,7 @@ static struct spi_driver tpm_tis_spi_driver = {
> .pm = &tpm_tis_pm,
> .of_match_table = of_match_ptr(of_tis_spi_match),
> .acpi_match_table = ACPI_PTR(acpi_tis_spi_match),
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = tpm_tis_spi_driver_probe,
> .remove = tpm_tis_spi_remove,
> --
> 2.27.0.111.gc72c7da667-goog
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
prev parent reply other threads:[~2020-06-23 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 21:20 [PATCH] tpm_tis_spi: Prefer async probe Douglas Anderson
2020-06-22 14:56 ` Doug Anderson
2020-06-23 1:36 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623013614.GJ28795@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).