From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 494E0C433F7 for ; Thu, 16 Jul 2020 19:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F7DA2065F for ; Thu, 16 Jul 2020 19:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eUF5kUcP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728907AbgGPTNd (ORCPT ); Thu, 16 Jul 2020 15:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729357AbgGPTNc (ORCPT ); Thu, 16 Jul 2020 15:13:32 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CD3C061755 for ; Thu, 16 Jul 2020 12:13:32 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id j19so5294271pgm.11 for ; Thu, 16 Jul 2020 12:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=P2Y3x3UF7aakg+eDh/JCMQ/ujg3OM7agEmMMQHUiWYw=; b=eUF5kUcP1I8IOHUVxI3FxJ/qxspiNpwWZ1kyR1myyi5d/rlntny124yFpRoBP0S+TU IULeT+p9QcpLBQJdqAMtaWb0tPOnG564tv2NICoimzwkKBF7b7R+TO++MSXHI9kPTYW4 dLCo8Qo5IB3QU1NMvjyOcqhje5qnF9Vt8u7nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=P2Y3x3UF7aakg+eDh/JCMQ/ujg3OM7agEmMMQHUiWYw=; b=FFiZ/VMf3UElWUDcm9KEJ0Puw+Q3fgBrWksY8q5kW8NxEuVqjM0psy5AXTxKfjJ/3g UsG54hb210E8F8RffbtJwi8zlEWnDZq7DA/gqsw8CzDU+VHXiH9rnPgxd+Bp80GMQUSp djzVSPmfqqP/AmExI0VYOEjOM/9o9mrnc1q0TKCyXRtzDFX88kaDxEauxyFYjkfsg+yv Jm3NVWonuNgzcTYetFjI7q8T3V8TMsNHs4HBuFseE0WqC0/9XuuhaPxzBSVZl7YmNkmU AssrfsacwQm3Rr3YORUHMgQsUmOneoUm82mhtRB8vEstc4sIkipsk2Tg4pvDuGQNyyeY bzlw== X-Gm-Message-State: AOAM533+oP4Yq87Z4o663cGBWKza737l2LvwGv3PQI2NtZN1I5+p4U65 Tgw4UdHVX01BMlYPe+yUCVKjFg== X-Google-Smtp-Source: ABdhPJy1fQTquN4l33pCs4D4d2Xd1YwY/TqBCMAGvi2rtEVPLt90LIg/bGHmjLscqWmRjzI4Zwih4g== X-Received: by 2002:a63:c150:: with SMTP id p16mr5583761pgi.141.1594926811598; Thu, 16 Jul 2020 12:13:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u14sm6060148pfk.211.2020.07.16.12.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 12:13:30 -0700 (PDT) Date: Thu, 16 Jul 2020 12:13:29 -0700 From: Kees Cook To: Randy Dunlap Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , linux-kernel@vger.kernel.org, Aleksa Sarai , Alexei Starovoitov , Al Viro , Andrew Morton , Andy Lutomirski , Christian Brauner , Christian Heimes , Daniel Borkmann , Deven Bowers , Dmitry Vyukov , Eric Biggers , Eric Chiang , Florian Weimer , James Morris , Jan Kara , Jann Horn , Jonathan Corbet , Lakshmi Ramasubramanian , Matthew Garrett , Matthew Wilcox , Michael Kerrisk , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mimi Zohar , Philippe =?iso-8859-1?Q?Tr=E9buchet?= , Scott Shell , Sean Christopherson , Shuah Khan , Steve Dower , Steve Grubb , Tetsuo Handa , Thibaut Sautereau , Vincent Strubel , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 7/7] ima: add policy support for the new file open MAY_OPENEXEC flag Message-ID: <202007161213.E8D240D98@keescook> References: <20200714181638.45751-1-mic@digikod.net> <20200714181638.45751-8-mic@digikod.net> <202007151339.283D7CD@keescook> <8df69733-0088-3e3c-9c3d-2610414cea2b@digikod.net> <61c05cb0-a956-3cc7-5dab-e11ebf0e95bf@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <61c05cb0-a956-3cc7-5dab-e11ebf0e95bf@infradead.org> Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Jul 16, 2020 at 07:59:20AM -0700, Randy Dunlap wrote: > On 7/16/20 7:40 AM, Mickaël Salaün wrote: > > > > On 15/07/2020 22:40, Kees Cook wrote: > >> On Tue, Jul 14, 2020 at 08:16:38PM +0200, Mickaël Salaün wrote: > >>> From: Mimi Zohar > >>> > >>> The kernel has no way of differentiating between a file containing data > >>> or code being opened by an interpreter. The proposed O_MAYEXEC > >>> openat2(2) flag bridges this gap by defining and enabling the > >>> MAY_OPENEXEC flag. > >>> > >>> This patch adds IMA policy support for the new MAY_OPENEXEC flag. > >>> > >>> Example: > >>> measure func=FILE_CHECK mask=^MAY_OPENEXEC > >>> appraise func=FILE_CHECK appraise_type=imasig mask=^MAY_OPENEXEC > >>> > >>> Signed-off-by: Mimi Zohar > >>> Reviewed-by: Lakshmi Ramasubramanian > >>> Acked-by: Mickaël Salaün > >> > >> (Process nit: if you're sending this on behalf of another author, then > >> this should be Signed-off-by rather than Acked-by.) > > > > I'm not a co-author of this patch. > > > > from Documentation/process/submitting-patches.rst: > > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery path. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Randy beat me to it. :) -- Kees Cook