From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9129C433E4 for ; Tue, 28 Jul 2020 19:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A56F2070A for ; Tue, 28 Jul 2020 19:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595966212; bh=t6ZBb6aKjOP/D53m5Lux0B4l1dQapES6T4xqgzSEF5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OVgUZX1/S9NcGKg+7B2D4Q++pYWvSYrhPEZY+krGj2XzZKeJP3G75cyKg+xFcxfKD KQfmkrxCzRKg3vV+O1YvxseIufw7CakAZHIS6nkzwlGeBlnC/YZAhrEquFq9Tm3REw kKJI/5Dnx2u79mcPMOImNWKaNkJKKLPL+naoGBBw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728928AbgG1T4s (ORCPT ); Tue, 28 Jul 2020 15:56:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:37176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728874AbgG1T4s (ORCPT ); Tue, 28 Jul 2020 15:56:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BC242070A; Tue, 28 Jul 2020 19:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595966208; bh=t6ZBb6aKjOP/D53m5Lux0B4l1dQapES6T4xqgzSEF5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=loUq6fsR9oQLkUjlfoFYvKPr2i6bqC2ehfaKt0sMzOhA6vcojo09dKpNP4VbTxW2E DF9qQ0DxImikxo7X1nRO5ZV5hDN+Br9zU/HrU0uT4QuGJg7KWwiO6dd6l5KMBHxbej P/ZKKP7Qx1kmZ0W6BZXMajP5aV5AwEY2cU4oWR0U= Date: Tue, 28 Jul 2020 21:56:40 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Mimi Zohar , Scott Branden , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 15/19] IMA: Add support for file reads without contents Message-ID: <20200728195640.GA342741@kroah.com> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-16-keescook@chromium.org> <1595856214.4841.86.camel@kernel.org> <202007281244.2F2681AE9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007281244.2F2681AE9@keescook> Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Jul 28, 2020 at 12:44:50PM -0700, Kees Cook wrote: > On Mon, Jul 27, 2020 at 09:23:34AM -0400, Mimi Zohar wrote: > > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > > > From: Scott Branden > > > > > > When the kernel_read_file LSM hook is called with contents=false, IMA > > > can appraise the file directly, without requiring a filled buffer. When > > > such a buffer is available, though, IMA can continue to use it instead > > > of forcing a double read here. > > > > > > Signed-off-by: Scott Branden > > > Link: https://lore.kernel.org/lkml/20200706232309.12010-10-scott.branden@broadcom.com/ > > > Signed-off-by: Kees Cook > > > > After adjusting the comment below. > > > > Reviewed-by: Mimi Zohar > > Sure! > > Greg, shall I send a v4 with added Reviews and the comment change or is > that minor enough that you're able to do it? v4 is needed, as this series is a mess of reviewes and you will have to redo at least one patch and drop some others, right? thanks, greg k-h