Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Mimi Zohar <zohar@linux.ibm.com>,
	linux-integrity@vger.kernel.org,
	Bruno Meneguele <bmeneg@redhat.com>
Subject: Re: [ima-evm-utils: PATCH 5/5] ima-evm-utils: travis: openssl gost engine
Date: Fri, 31 Jul 2020 22:40:44 +0200
Message-ID: <20200731204044.GC27841@dell5510> (raw)
In-Reply-To: <20200731202638.x5mnkz7hcpgbveu2@altlinux.org>

> Petr,

> On Fri, Jul 31, 2020 at 10:18:08PM +0200, Petr Vorel wrote:
> > > > +++ b/tests/install-gost-engine.sh
> > > > @@ -0,0 +1,10 @@
> > > > +#!/bin/sh
> > > > +
> > > > +openssl version
> > > > +
> > > > +git clone https://github.com/gost-engine/engine.git

> > > gost-engine master branch corresponds to openssl-3.0 which is probably
> > > not on Travis systems yet. I think branch `openssl_1_1_0` should be used.

> > >   git clone --branch openssl_1_1_0 https://github.com/gost-engine/engine.git

> > FYI: it work on current setup.
> > https://travis-ci.org/github/pevik/ima-evm-utils/builds/713815774

> I think `install-gost-engine.sh` is not executed in this line:

>   257 $ if [ "${SSL}" = "openssl" ]; then ./tests/install-gost-engine.sh; openssl version; fi   0.00s

Good catch!
$ ./tests/install-gost-engine.sh
OpenSSL 1.1.1g  21 Apr 2020
fatal: destination path 'engine' already exists and is not an empty directory.
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.1.1g", but
  required is at least "3.0" (found /usr/lib64/libcrypto.so, )
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:456 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindOpenSSL.cmake:486 (find_package_handle_standard_args)
  CMakeLists.txt:11 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/pvorel/install/src/ima-evm-utils.git/engine/CMakeFiles/CMakeOutput.log".
make: *** No rule to make target 'install'.  Stop.

And when using suggested branch openssl_1_1_0, it also fails on make install
$ ./tests/install-gost-engine.sh
OpenSSL 1.1.1g  21 Apr 2020
Cloning into 'engine'...
remote: Enumerating objects: 63, done.
remote: Counting objects: 100% (63/63), done.
remote: Compressing objects: 100% (40/40), done.
remote: Total 2738 (delta 33), reused 32 (delta 21), pack-reused 2675
Receiving objects: 100% (2738/2738), 2.48 MiB | 2.09 MiB/s, done.
Resolving deltas: 100% (1735/1735), done.
-- The C compiler identification is GNU 10.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found OpenSSL: /usr/lib64/libcrypto.so (found suitable version "1.1.1g", minimum required is "1.1")
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Searching 16 bit integer - Using unsigned short
-- Check if the system is big endian - little endian
-- LITTLE_ENDIAN
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pvorel/install/src/ima-evm-utils.git/engine
make: *** No rule to make target 'install'.  Stop.

=> It'd be good to fix this and add some test with SSL=openssl variable.
But the branch would have to be updated time to time.

BTW do you plan to test other crypto libraries?

Kind regards,
Petr

  reply index

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 18:24 [ima-evm-utils: PATCH 0/5] initial travis support Mimi Zohar
2020-07-31 18:24 ` [ima-evm-utils: PATCH 1/5] ima-evm-utils: travis: define travis.yml Mimi Zohar
2020-07-31 18:24 ` [ima-evm-utils: PATCH 2/5] ima-evm-utils: travis: download, compile, and install a swTPM Mimi Zohar
2020-07-31 18:24 ` [ima-evm-utils: PATCH 3/5] ima-evm-utils: travis: dependency on TSS for initializing software TPM Mimi Zohar
2020-07-31 18:24 ` [ima-evm-utils: PATCH 4/5] ima-evm-utils: travis: support tpm2-tss Mimi Zohar
2020-07-31 18:24 ` [ima-evm-utils: PATCH 5/5] ima-evm-utils: travis: openssl gost engine Mimi Zohar
2020-07-31 18:56   ` Vitaly Chikunov
2020-07-31 20:18     ` Petr Vorel
2020-07-31 20:26       ` Vitaly Chikunov
2020-07-31 20:40         ` Petr Vorel [this message]
2020-07-31 21:06           ` Vitaly Chikunov
2020-07-31 22:32             ` Mimi Zohar
2020-08-03  3:09               ` Mimi Zohar
2020-08-03 13:07                 ` Petr Vorel
2020-08-03 14:29                   ` Mimi Zohar
2020-08-03 16:46                     ` Petr Vorel
2020-08-03 17:16                       ` Mimi Zohar
2020-08-04  7:22                         ` Petr Vorel
2020-08-04  7:54                           ` Petr Vorel
2020-08-04 13:23                             ` Mimi Zohar
2020-08-05  9:42                               ` Petr Vorel
2020-08-05 13:31                                 ` Mimi Zohar
2020-08-05 16:23                                   ` Vitaly Chikunov
2020-08-05 16:18                                 ` Vitaly Chikunov
2020-08-11 17:33                                 ` Petr Vorel
2020-08-11 22:04                                   ` Mimi Zohar
2020-08-12 13:05                                     ` Petr Vorel
2020-08-03 16:32               ` Vitaly Chikunov
2020-08-03 16:36                 ` Petr Vorel
2020-08-03 17:26             ` Mimi Zohar
2020-08-03 18:42               ` Vitaly Chikunov
2020-08-03  2:53           ` Mimi Zohar
2020-08-03 13:11             ` Petr Vorel
2020-08-03 14:33               ` Mimi Zohar
2020-08-04 12:05   ` [ima-evm-utils: PATCH v1 " Mimi Zohar
2020-08-04 14:45     ` Vitaly Chikunov
2020-08-04 18:11       ` Mimi Zohar
2020-07-31 20:19 ` [ima-evm-utils: PATCH 0/5] initial travis support Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731204044.GC27841@dell5510 \
    --to=pvorel@suse.cz \
    --cc=bmeneg@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=vt@altlinux.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git