From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-integrity@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference
Date: Tue, 13 Oct 2020 09:31:39 -0500 [thread overview]
Message-ID: <20201013143139.GA12418@sequoia> (raw)
In-Reply-To: <20201009160654.GA26881@linux.intel.com>
Sorry for coming in so late, I've been on an extended vacation with
little connectivity.
On 2020-10-09 19:06:54, Jarkko Sakkinen wrote:
> On Thu, Oct 08, 2020 at 05:09:06PM +0800, Kai-Heng Feng wrote:
> > > I do not have yet any reasonable answer to this and my v5.10 PR is
> > > running late. Does everyone agree that I should revert the patch?
> >
> > Given that there are multiple users confirmed reverting the commit
> > helps, can you please revert it and Cc: linux-stable?
>
> I already sent the PR, but I schedule the revert to my rc2 PR.
I'll try to better understand what's going on. I, too, am confused about
how the change would introduce the reported regression. I've only
skimmed the thread so far but it feels like there's possibly a latent
issue that the change may be uncovering on certain systems.
FWIW, we've had this patch applied to our internal kernel for a month
and haven't seen any issues.
Tyler
>
> > Thanks!
> >
> > Kai-Heng
>
> /Jarkko
>
next prev parent reply other threads:[~2020-10-13 14:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 12:31 [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference Kai-Heng Feng
2020-09-28 14:06 ` Jarkko Sakkinen
2020-09-28 14:16 ` Kai-Heng Feng
[not found] ` <20200928155215.GA92669@linux.intel.com>
2020-09-28 16:15 ` Ard Biesheuvel
2020-09-28 16:26 ` Ard Biesheuvel
2020-09-28 17:12 ` Jarkko Sakkinen
2020-09-28 18:05 ` Kenneth R. Crudup
2020-09-29 17:52 ` Mimi Zohar
2020-09-30 2:20 ` Jarkko Sakkinen
2020-10-08 9:09 ` Kai-Heng Feng
2020-10-09 16:06 ` Jarkko Sakkinen
2020-10-13 14:31 ` Tyler Hicks [this message]
2020-10-13 14:33 ` Jarkko Sakkinen
2020-10-20 21:07 ` Mimi Zohar
2020-10-21 5:48 ` Tyler Hicks
[not found] ` <2A43F8DD-7E07-4435-9666-63B8105ABF82@canonical.com>
2020-10-27 5:08 ` Tyler Hicks
2020-10-28 15:41 ` [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log Tyler Hicks
2020-10-28 16:30 ` Tyler Hicks
2020-10-28 17:39 ` Tyler Hicks
2020-10-30 6:41 ` Kai-Heng Feng
2020-11-04 2:12 ` Kenneth R. Crudup
2020-10-30 4:46 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013143139.GA12418@sequoia \
--to=tyhicks@linux.microsoft.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).