From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36ECC4361A for ; Fri, 4 Dec 2020 15:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B0B822B43 for ; Fri, 4 Dec 2020 15:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730395AbgLDPb1 (ORCPT ); Fri, 4 Dec 2020 10:31:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:38116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729840AbgLDPb0 (ORCPT ); Fri, 4 Dec 2020 10:31:26 -0500 Date: Fri, 4 Dec 2020 17:30:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607095846; bh=NHKkkiVjcEytL4TWZgxQrssmxGcP3N0tIxymDLc440g=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=qBI1LL+o1KhplcvIkiunZUov3Mg8GnpFsgg7rJ/ut5AHZOEsNV4OUKeAFdFG2Oa0W mYkMXl5jIgoqDfpjRIBbIgHXQ1vGWbb0OJFqvLLg+/XuL+lBJh7xa0Q/BiAj3ikEL8 hFI1078z6KQxlbDqHQLWcwwhNDknoAl1RP1j3k/GDVli6LOaHaOgW7IGuTTAWPD+b3 SIOWgpOoZsKoIaw8zdMRVVevSi2HKOvRJq245q2Vh0NLbYcDJYJ++WCfiaQonzWDoC iQExKMaT6wKrDsc7Kf/xO0p6HpdWfM32hCMFmYWeBE/i7pedyt6CyIQgLp2+OMK7WD yYC7QSsicJNyw== From: Jarkko Sakkinen To: gmail Elaine Palmer Cc: Sumit Garg , jarkko.sakkinen@linux.intel.com, zohar@linux.ibm.com, jejb@linux.ibm.com, dhowells@redhat.com, jens.wiklander@linaro.org, corbet@lwn.net, jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com, janne.karhunen@gmail.com, daniel.thompson@linaro.org, Markus.Wamser@mixed-mode.de, lhinds@redhat.com, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, Kenneth Goldman , gcwilson@linux.ibm.com, zgu@us.ibm.com, stefanb@us.ibm.com, NAYNA JAIN1 Subject: Re: [PATCH v8 3/4] doc: trusted-encrypted: updates with TEE as a new trust source Message-ID: <20201204153037.GC4922@kernel.org> References: <1604419306-26105-1-git-send-email-sumit.garg@linaro.org> <1604419306-26105-4-git-send-email-sumit.garg@linaro.org> <81A6B61D-3811-4957-B270-52AE5FA6DE4F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81A6B61D-3811-4957-B270-52AE5FA6DE4F@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Dec 02, 2020 at 02:34:07PM -0500, gmail Elaine Palmer wrote: > Hi Sumit, > > Thank you for the detailed descriptions and examples of trust sources > for Trusted Keys. A group of us in IBM (Stefan Berger, Ken Goldman, > Zhongshu Gu, Nayna Jain, Elaine Palmer, George Wilson, Mimi Zohar) > have been doing related work for quite some time, and we have one > primary concern and some suggested changes to the document. > > Our primary concern is that describing a TEE as a Trust Source needs > to be more specific. For example, "ARM TrustZone" is not sufficient, > but "wolfSSL embedded SSL/TLS library with ARM TrustZone > CryptoCell-310" is. Just because a key is protected by software > running in a TEE is not enough to establish trust. Just like > cryptographic modules, a Trust Source should be defined as a specific > implementation on specific hardware with well-documented environmental > assumptions, dependencies, and threats. > > In addition to the above concern, our suggested changes are inline > below. In order to give a decent review comment it should have two ingredients: - Where the existing line of code / text / whatever goes wrong. - How it should modified and why that makes sense. And use as plain English and non-academic terms as possible, if it is documentation. Further, scope is only the kernel implementation, no more or no less. "do this" is not unfortunately an argument. Feedback is welcome when it is supported by something common sensse. Some meta suggestion of related to email: Please also use a proper email client and split your paragraphs into at most 80 character lines with new line characters when writing email. I prefer to use 72 character line length so that there's some space for longer email threads. /Jarkko