linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, zohar@linux.ibm.com,
	dmitry.kasatkin@gmail.com
Subject: Re: [PATCH v2 2/3] tests: Add program to create IMA signature with new API call
Date: Wed, 28 Apr 2021 01:26:01 +0300	[thread overview]
Message-ID: <20210427222601.ednotpq7gur36g62@altlinux.org> (raw)
In-Reply-To: <20210427193133.1718367-3-stefanb@linux.ibm.com>

Stefan,

On Tue, Apr 27, 2021 at 03:31:32PM -0400, Stefan Berger wrote:
> Since the new API call is not used by evmctl, implement a test program
> 'create_ima_signature' to use it. Extend _evmctl_sign to also created
> IMA v2 signatures with RSA keys using this test program and compare the
> results.
> 
> Evmctl's signature creation path is unmodified at this point, so the tests
> ensure that the existing sign_hash_v2 and the new sign_hash_v2_pkey create
> identical (RSA) signatures.
> 
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
>  tests/Makefile.am            |   6 ++
>  tests/create_ima_signature.c | 111 +++++++++++++++++++++++++++++++++++

Why not add this to evmctl?

Thanks,

>  tests/sign_verify.test       |  21 ++++++-
>  3 files changed, 136 insertions(+), 2 deletions(-)
>  create mode 100644 tests/create_ima_signature.c

  reply	other threads:[~2021-04-27 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 19:31 [PATCH v2 0/3] ima-evm-utils: Implement function to only create IMA signature Stefan Berger
2021-04-27 19:31 ` [PATCH v2 1/3] libimaevm: Implement imaevm_create_ima_signature Stefan Berger
2021-04-27 19:31 ` [PATCH v2 2/3] tests: Add program to create IMA signature with new API call Stefan Berger
2021-04-27 22:26   ` Vitaly Chikunov [this message]
2021-04-27 23:55     ` Stefan Berger
2021-04-27 19:31 ` [PATCH v2 3/3] libimaevm: Have sign_hash_v2 call sign_hash_v2_pkey after reading key file Stefan Berger
2021-05-10 13:55 ` [PATCH v2 0/3] ima-evm-utils: Implement function to only create IMA signature Stefan Berger
2021-05-10 15:40   ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427222601.ednotpq7gur36g62@altlinux.org \
    --to=vt@altlinux.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).