linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH v5 0/3] ima-evm-utils: Add --keyid option
Date: Fri, 7 May 2021 04:43:32 +0300	[thread overview]
Message-ID: <20210507014332.qrgvzaana53yzp4g@altlinux.org> (raw)
In-Reply-To: <a187174e-9a57-9aad-790b-41eaca424e35@linux.ibm.com>

Stefan,

On Thu, May 06, 2021 at 04:10:25PM -0400, Stefan Berger wrote:
> On 5/5/21 11:46 PM, Vitaly Chikunov wrote:
> > Allow user to set signature's keyid using `--keyid' option. Keyid should
> > correspond to SKID in certificate. When keyid is calculated using SHA-1
> > in libimaevm it may mismatch keyid extracted by the kernel from SKID of
> > certificate (the way public key is presented to the kernel), thus making
> > signatures not verifiable. This may happen when certificate is using non
> > SHA-1 SKID (see rfc7093) or just 'unique number' (see rfc5280 4.2.1.2).
> > As a last resort user may specify arbitrary keyid using the new option.
> > Certificate @filename could be used instead of the hex number. And,
> > third option is to read keyid from the cert appended to the key file.
> > 
> > These commits create backward incompatible ABI change for libimaevm,
> >   thus soname should be incremented on release.
> 
> I hope this will not be forgotten about. Maybe it should be part of this
> series here?

https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

  "Update the version information only immediately before a public
  release of your software."

I believe we should follow this.

Thanks,


  reply	other threads:[~2021-05-07  1:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  3:46 [PATCH v5 0/3] ima-evm-utils: Add --keyid option Vitaly Chikunov
2021-05-06  3:47 ` [PATCH v5 1/3] ima-evm-utils: Allow manual setting keyid for signing Vitaly Chikunov
2021-05-06  3:47 ` [PATCH v5 2/3] ima-evm-utils: Allow manual setting keyid from a cert file Vitaly Chikunov
2021-05-06 20:17   ` Stefan Berger
2021-05-06  3:47 ` [PATCH v5 3/3] ima-evm-utils: Read keyid from the cert appended to the key file Vitaly Chikunov
2021-05-06 20:10 ` [PATCH v5 0/3] ima-evm-utils: Add --keyid option Stefan Berger
2021-05-07  1:43   ` Vitaly Chikunov [this message]
2021-05-07 14:01     ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210507014332.qrgvzaana53yzp4g@altlinux.org \
    --to=vt@altlinux.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).