linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Bob Picco" <robert.picco@hp.com>,
	"Clemens Ladisch" <clemens@ladisch.de>,
	"C. Scott Ananian" <cananian@alumni.princeton.edu>,
	"cs.c" <support.linux@omnikey.com>,
	"Dave Safford" <safford@watson.ibm.com>,
	"David Airlie" <airlied@linux.ie>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Harald Welte" <laforge@gnumonks.org>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jerome Glisse" <j.glisse@gmail.com>,
	"Kanoj Sarcar" <kanoj@sgi.com>, "Kylene Hall" <kjhall@us.ibm.com>,
	"Lijun Pan" <ljp@linux.ibm.com>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	linux-integrity@vger.kernel.org,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"Matt Mackall" <mpm@selenic.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michael Neuling" <mikey@neuling.org>,
	"Paul Fulghum" <paulkf@microgate.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Peter Huewe" <peterhuewe@gmx.de>,
	"Reiner Sailer" <sailer@watson.ibm.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"Thirupathaiah Annapureddy" <thiruan@microsoft.com>,
	"Tyrel Datwyler" <tyreld@linux.ibm.com>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"van Doorn" <leendert@watson.ibm.com>
Subject: Re: [PATCH 00/16] Rid W=1 warnings from Char
Date: Fri, 21 May 2021 08:22:36 +0100	[thread overview]
Message-ID: <20210521072236.GX2549456@dell> (raw)
In-Reply-To: <CAK8P3a0VujuG8eU_CEVSvzbk4nAJz8fStedM5eMUrLAr9EJxDQ@mail.gmail.com>

On Thu, 20 May 2021, Arnd Bergmann wrote:

> On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (16):
> >   char: pcmcia: cm4000_cs: Remove unused variable 'tmp'
> >   char: pcmcia: cm4040_cs: Remove unused variable 'uc'
> >   char: random: Include header containing our prototypes
> >   char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
> >   char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
> >   char: applicom: Remove 3 unused variables 'ret' and 2 instances of
> >     'byte_reset_it'
> >   char: tpm: tpm1-cmd: Fix a couple of misnamed functions
> >   char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours
> >   char: agp: backend: Demote some non-conformant kernel-doc headers
> >   char: agp: frontend: Include header file containing our prototypes
> >   char: agp: via-agp: Remove unused variable 'current_size'
> >   char: hpet: Remove unused variable 'm'
> >   char: agp: generic: Place braces around optimised out function in if()
> >   char: agp: uninorth-agp: Remove unused variable 'size'
> >   char: hw_random: pseries-rng: Demote non-conformant kernel-doc header
> >   char: mem: Provide local prototype for non-static function
> 
> Thanks a lot!
> 
> I've looked all the patches now and commented on patches 6 and 16.
> With my comments addressed
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd.

Would it be possible for the remaining 14 patches to be taken in
please?  I will work on the 2 Arnd commented on in due course and
resubmit them independently.

TIA.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-05-21  7:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones
2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones
2021-05-20 16:41   ` Jarkko Sakkinen
2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones
2021-05-20 16:43   ` Jarkko Sakkinen
2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann
2021-05-21  7:22   ` Lee Jones [this message]
2021-05-21  7:42     ` Greg Kroah-Hartman
2021-05-21  7:44       ` Greg Kroah-Hartman
2021-05-21  7:56         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521072236.GX2549456@dell \
    --to=lee.jones@linaro.org \
    --cc=Jason@zx2c4.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=cananian@alumni.princeton.edu \
    --cc=clemens@ladisch.de \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=j.glisse@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kanoj@sgi.com \
    --cc=kjhall@us.ibm.com \
    --cc=laforge@gnumonks.org \
    --cc=leendert@watson.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ljp@linux.ibm.com \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=mpm@selenic.com \
    --cc=paulkf@microgate.com \
    --cc=paulus@samba.org \
    --cc=peterhuewe@gmx.de \
    --cc=robert.picco@hp.com \
    --cc=safford@watson.ibm.com \
    --cc=sailer@watson.ibm.com \
    --cc=support.linux@omnikey.com \
    --cc=thiruan@microsoft.com \
    --cc=tyreld@linux.ibm.com \
    --cc=tytso@mit.edu \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).