* [PATCH 00/16] Rid W=1 warnings from Char @ 2021-05-20 12:13 Lee Jones 2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: Lee Jones @ 2021-05-20 12:13 UTC (permalink / raw) To: lee.jones Cc: linux-kernel, Arnd Bergmann, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, dwmw2, Greg Kroah-Hartman, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, linux-crypto, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, paulkf, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (16): char: pcmcia: cm4000_cs: Remove unused variable 'tmp' char: pcmcia: cm4040_cs: Remove unused variable 'uc' char: random: Include header containing our prototypes char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: applicom: Remove 3 unused variables 'ret' and 2 instances of 'byte_reset_it' char: tpm: tpm1-cmd: Fix a couple of misnamed functions char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours char: agp: backend: Demote some non-conformant kernel-doc headers char: agp: frontend: Include header file containing our prototypes char: agp: via-agp: Remove unused variable 'current_size' char: hpet: Remove unused variable 'm' char: agp: generic: Place braces around optimised out function in if() char: agp: uninorth-agp: Remove unused variable 'size' char: hw_random: pseries-rng: Demote non-conformant kernel-doc header char: mem: Provide local prototype for non-static function drivers/char/agp/backend.c | 4 +- drivers/char/agp/frontend.c | 1 + drivers/char/agp/generic.c | 3 +- drivers/char/agp/uninorth-agp.c | 3 -- drivers/char/agp/via-agp.c | 3 -- drivers/char/applicom.c | 10 ++-- drivers/char/hpet.c | 4 +- drivers/char/hw_random/pseries-rng.c | 2 +- drivers/char/mem.c | 2 + drivers/char/pcmcia/cm4000_cs.c | 3 +- drivers/char/pcmcia/cm4040_cs.c | 3 +- drivers/char/pcmcia/synclink_cs.c | 74 +++++++++++++++------------- drivers/char/random.c | 1 + drivers/char/tpm/tpm1-cmd.c | 4 +- drivers/char/tpm/tpm_ftpm_tee.c | 6 +-- 15 files changed, 60 insertions(+), 63 deletions(-) Cc: Arnd Bergmann <arnd@arndb.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Bob Picco <robert.picco@hp.com> Cc: Clemens Ladisch <clemens@ladisch.de> Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu> Cc: "cs.c" <support.linux@omnikey.com> Cc: Dave Safford <safford@watson.ibm.com> Cc: David Airlie <airlied@linux.ie> Cc: dwmw2@infradead.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Harald Welte <laforge@gnumonks.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Jerome Glisse <j.glisse@gmail.com> Cc: Kanoj Sarcar <kanoj@sgi.com> Cc: Kylene Hall <kjhall@us.ibm.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Lijun Pan <ljp@linux.ibm.com> Cc: linux-crypto@vger.kernel.org Cc: linux-integrity@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Matt Mackall <mpm@selenic.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Michael Neuling <mikey@neuling.org> Cc: paulkf@microgate.com Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Huewe <peterhuewe@gmx.de> Cc: Reiner Sailer <sailer@watson.ibm.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> Cc: Tyrel Datwyler <tyreld@linux.ibm.com> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org> Cc: van Doorn <leendert@watson.ibm.com> -- 2.31.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions 2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones @ 2021-05-20 12:13 ` Lee Jones 2021-05-20 16:41 ` Jarkko Sakkinen 2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones 2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann 2 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-05-20 12:13 UTC (permalink / raw) To: lee.jones Cc: linux-kernel, Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, van Doorn, Dave Safford, Reiner Sailer, Kylene Hall, linux-integrity Fixes the following W=1 kernel build warning(s): drivers/char/tpm/tpm1-cmd.c:325: warning: expecting prototype for tpm_startup(). Prototype was for tpm1_startup() instead drivers/char/tpm/tpm1-cmd.c:621: warning: expecting prototype for tpm_continue_selftest(). Prototype was for tpm1_continue_selftest() instead Cc: Peter Huewe <peterhuewe@gmx.de> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: van Doorn <leendert@watson.ibm.com> Cc: Dave Safford <safford@watson.ibm.com> Cc: Reiner Sailer <sailer@watson.ibm.com> Cc: Kylene Hall <kjhall@us.ibm.com> Cc: linux-integrity@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/char/tpm/tpm1-cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm1-cmd.c b/drivers/char/tpm/tpm1-cmd.c index ca7158fa6e6cd..f7dc986fa4a0a 100644 --- a/drivers/char/tpm/tpm1-cmd.c +++ b/drivers/char/tpm/tpm1-cmd.c @@ -312,7 +312,7 @@ unsigned long tpm1_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal) #define TPM_ST_CLEAR 1 /** - * tpm_startup() - turn on the TPM + * tpm1_startup() - turn on the TPM * @chip: TPM chip to use * * Normally the firmware should start the TPM. This function is provided as a @@ -611,7 +611,7 @@ int tpm1_pcr_read(struct tpm_chip *chip, u32 pcr_idx, u8 *res_buf) #define TPM_ORD_CONTINUE_SELFTEST 83 /** - * tpm_continue_selftest() - run TPM's selftest + * tpm1_continue_selftest() - run TPM's selftest * @chip: TPM chip to use * * Returns 0 on success, < 0 in case of fatal error or a value > 0 representing -- 2.31.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions 2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones @ 2021-05-20 16:41 ` Jarkko Sakkinen 0 siblings, 0 replies; 10+ messages in thread From: Jarkko Sakkinen @ 2021-05-20 16:41 UTC (permalink / raw) To: Lee Jones Cc: linux-kernel, Peter Huewe, Jason Gunthorpe, van Doorn, Dave Safford, Reiner Sailer, Kylene Hall, linux-integrity On Thu, May 20, 2021 at 01:13:38PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/char/tpm/tpm1-cmd.c:325: warning: expecting prototype for tpm_startup(). Prototype was for tpm1_startup() instead > drivers/char/tpm/tpm1-cmd.c:621: warning: expecting prototype for tpm_continue_selftest(). Prototype was for tpm1_continue_selftest() instead > > Cc: Peter Huewe <peterhuewe@gmx.de> > Cc: Jarkko Sakkinen <jarkko@kernel.org> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: van Doorn <leendert@watson.ibm.com> > Cc: Dave Safford <safford@watson.ibm.com> > Cc: Reiner Sailer <sailer@watson.ibm.com> > Cc: Kylene Hall <kjhall@us.ibm.com> > Cc: linux-integrity@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Thanks, I'll apply this. > --- > drivers/char/tpm/tpm1-cmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm1-cmd.c b/drivers/char/tpm/tpm1-cmd.c > index ca7158fa6e6cd..f7dc986fa4a0a 100644 > --- a/drivers/char/tpm/tpm1-cmd.c > +++ b/drivers/char/tpm/tpm1-cmd.c > @@ -312,7 +312,7 @@ unsigned long tpm1_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal) > #define TPM_ST_CLEAR 1 > > /** > - * tpm_startup() - turn on the TPM > + * tpm1_startup() - turn on the TPM > * @chip: TPM chip to use > * > * Normally the firmware should start the TPM. This function is provided as a > @@ -611,7 +611,7 @@ int tpm1_pcr_read(struct tpm_chip *chip, u32 pcr_idx, u8 *res_buf) > > #define TPM_ORD_CONTINUE_SELFTEST 83 > /** > - * tpm_continue_selftest() - run TPM's selftest > + * tpm1_continue_selftest() - run TPM's selftest > * @chip: TPM chip to use > * > * Returns 0 on success, < 0 in case of fatal error or a value > 0 representing > -- > 2.31.1 > > /Jarkko ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours 2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones 2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones @ 2021-05-20 12:13 ` Lee Jones 2021-05-20 16:43 ` Jarkko Sakkinen 2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann 2 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-05-20 12:13 UTC (permalink / raw) To: lee.jones Cc: linux-kernel, Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Thirupathaiah Annapureddy, linux-integrity Fixes the following W=1 kernel build warning(s): drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe' drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe' drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove' drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove' drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead Cc: Peter Huewe <peterhuewe@gmx.de> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> Cc: linux-integrity@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/char/tpm/tpm_ftpm_tee.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c index 2ccdf8ac69948..2d9c0ecd43f0a 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data) /** * ftpm_tee_probe() - initialize the fTPM - * @pdev: the platform_device description. + * @dev: the platform_device description. * * Return: * On success, 0. On failure, -errno. @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev) /** * ftpm_tee_remove() - remove the TPM device - * @pdev: the platform_device description. + * @dev: the platform_device description. * * Return: * 0 always. @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev) } /** - * ftpm_tee_shutdown() - shutdown the TPM device + * ftpm_plat_tee_shutdown() - shutdown the TPM device * @pdev: the platform_device description. */ static void ftpm_plat_tee_shutdown(struct platform_device *pdev) -- 2.31.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours 2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones @ 2021-05-20 16:43 ` Jarkko Sakkinen 0 siblings, 0 replies; 10+ messages in thread From: Jarkko Sakkinen @ 2021-05-20 16:43 UTC (permalink / raw) To: Lee Jones Cc: linux-kernel, Peter Huewe, Jason Gunthorpe, Thirupathaiah Annapureddy, linux-integrity On Thu, May 20, 2021 at 01:13:39PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead > > Cc: Peter Huewe <peterhuewe@gmx.de> > Cc: Jarkko Sakkinen <jarkko@kernel.org> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> > Cc: linux-integrity@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> /Jarkko > --- > drivers/char/tpm/tpm_ftpm_tee.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c > index 2ccdf8ac69948..2d9c0ecd43f0a 100644 > --- a/drivers/char/tpm/tpm_ftpm_tee.c > +++ b/drivers/char/tpm/tpm_ftpm_tee.c > @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data) > > /** > * ftpm_tee_probe() - initialize the fTPM > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * On success, 0. On failure, -errno. > @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev) > > /** > * ftpm_tee_remove() - remove the TPM device > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * 0 always. > @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev) > } > > /** > - * ftpm_tee_shutdown() - shutdown the TPM device > + * ftpm_plat_tee_shutdown() - shutdown the TPM device > * @pdev: the platform_device description. > */ > static void ftpm_plat_tee_shutdown(struct platform_device *pdev) > -- > 2.31.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/16] Rid W=1 warnings from Char 2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones 2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones 2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones @ 2021-05-20 12:56 ` Arnd Bergmann 2021-05-21 7:22 ` Lee Jones 2 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2021-05-20 12:56 UTC (permalink / raw) To: Lee Jones Cc: Linux Kernel Mailing List, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, David Woodhouse, Greg Kroah-Hartman, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, Paul Fulghum, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (16): > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > char: random: Include header containing our prototypes > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > 'byte_reset_it' > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > char: agp: backend: Demote some non-conformant kernel-doc headers > char: agp: frontend: Include header file containing our prototypes > char: agp: via-agp: Remove unused variable 'current_size' > char: hpet: Remove unused variable 'm' > char: agp: generic: Place braces around optimised out function in if() > char: agp: uninorth-agp: Remove unused variable 'size' > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > char: mem: Provide local prototype for non-static function Thanks a lot! I've looked all the patches now and commented on patches 6 and 16. With my comments addressed Reviewed-by: Arnd Bergmann <arnd@arndb.de> Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/16] Rid W=1 warnings from Char 2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann @ 2021-05-21 7:22 ` Lee Jones 2021-05-21 7:42 ` Greg Kroah-Hartman 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-05-21 7:22 UTC (permalink / raw) To: Arnd Bergmann Cc: Linux Kernel Mailing List, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, David Woodhouse, Greg Kroah-Hartman, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, Paul Fulghum, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn On Thu, 20 May 2021, Arnd Bergmann wrote: > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (16): > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > char: random: Include header containing our prototypes > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > 'byte_reset_it' > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > char: agp: backend: Demote some non-conformant kernel-doc headers > > char: agp: frontend: Include header file containing our prototypes > > char: agp: via-agp: Remove unused variable 'current_size' > > char: hpet: Remove unused variable 'm' > > char: agp: generic: Place braces around optimised out function in if() > > char: agp: uninorth-agp: Remove unused variable 'size' > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > char: mem: Provide local prototype for non-static function > > Thanks a lot! > > I've looked all the patches now and commented on patches 6 and 16. > With my comments addressed > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd. Would it be possible for the remaining 14 patches to be taken in please? I will work on the 2 Arnd commented on in due course and resubmit them independently. TIA. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/16] Rid W=1 warnings from Char 2021-05-21 7:22 ` Lee Jones @ 2021-05-21 7:42 ` Greg Kroah-Hartman 2021-05-21 7:44 ` Greg Kroah-Hartman 0 siblings, 1 reply; 10+ messages in thread From: Greg Kroah-Hartman @ 2021-05-21 7:42 UTC (permalink / raw) To: Lee Jones Cc: Arnd Bergmann, Linux Kernel Mailing List, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, David Woodhouse, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, Paul Fulghum, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > Lee Jones (16): > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > char: random: Include header containing our prototypes > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > 'byte_reset_it' > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > char: agp: frontend: Include header file containing our prototypes > > > char: agp: via-agp: Remove unused variable 'current_size' > > > char: hpet: Remove unused variable 'm' > > > char: agp: generic: Place braces around optimised out function in if() > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > char: mem: Provide local prototype for non-static function > > > > Thanks a lot! > > > > I've looked all the patches now and commented on patches 6 and 16. > > With my comments addressed > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Thanks Arnd. > > Would it be possible for the remaining 14 patches to be taken in > please? I will work on the 2 Arnd commented on in due course and > resubmit them independently. Yes, I can queue them up, thanks. greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/16] Rid W=1 warnings from Char 2021-05-21 7:42 ` Greg Kroah-Hartman @ 2021-05-21 7:44 ` Greg Kroah-Hartman 2021-05-21 7:56 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Greg Kroah-Hartman @ 2021-05-21 7:44 UTC (permalink / raw) To: Lee Jones Cc: Arnd Bergmann, Linux Kernel Mailing List, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, David Woodhouse, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, Paul Fulghum, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (16): > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > char: random: Include header containing our prototypes > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > 'byte_reset_it' > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > char: agp: frontend: Include header file containing our prototypes > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > char: hpet: Remove unused variable 'm' > > > > char: agp: generic: Place braces around optimised out function in if() > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > > char: mem: Provide local prototype for non-static function > > > > > > Thanks a lot! > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > With my comments addressed > > > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > > Thanks Arnd. > > > > Would it be possible for the remaining 14 patches to be taken in > > please? I will work on the 2 Arnd commented on in due course and > > resubmit them independently. > > Yes, I can queue them up, thanks. Wait, I can take the ones for code that I maintain, not for others. drivers/char/ is "fun" in that some subdirs have active trees/maintainers that are not me and Arnd so they go to Linus through other ways. I'll queue up the ones that I am "allowed" to and you will get the emails from that. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/16] Rid W=1 warnings from Char 2021-05-21 7:44 ` Greg Kroah-Hartman @ 2021-05-21 7:56 ` Lee Jones 0 siblings, 0 replies; 10+ messages in thread From: Lee Jones @ 2021-05-21 7:56 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Arnd Bergmann, Linux Kernel Mailing List, Benjamin Herrenschmidt, Bob Picco, Clemens Ladisch, C. Scott Ananian, cs.c, Dave Safford, David Airlie, David Woodhouse, Harald Welte, Herbert Xu, Jarkko Sakkinen, Jason A. Donenfeld, Jason Gunthorpe, Jerome Glisse, Kanoj Sarcar, Kylene Hall, Lijun Pan, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-integrity, linuxppc-dev, Matt Mackall, Michael Ellerman, Michael Neuling, Paul Fulghum, Paul Mackerras, Peter Huewe, Reiner Sailer, Theodore Ts'o, Thirupathaiah Annapureddy, Tyrel Datwyler, Uwe Kleine-König, van Doorn On Fri, 21 May 2021, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > niggly little warnings. > > > > > > > > > > Lee Jones (16): > > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > > char: random: Include header containing our prototypes > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > > 'byte_reset_it' > > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > > char: agp: frontend: Include header file containing our prototypes > > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > > char: hpet: Remove unused variable 'm' > > > > > char: agp: generic: Place braces around optimised out function in if() > > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > > > char: mem: Provide local prototype for non-static function > > > > > > > > Thanks a lot! > > > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > > With my comments addressed > > > > > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > > > > Thanks Arnd. > > > > > > Would it be possible for the remaining 14 patches to be taken in > > > please? I will work on the 2 Arnd commented on in due course and > > > resubmit them independently. > > > > Yes, I can queue them up, thanks. > > Wait, I can take the ones for code that I maintain, not for others. > drivers/char/ is "fun" in that some subdirs have active > trees/maintainers that are not me and Arnd so they go to Linus through > other ways. I'll queue up the ones that I am "allowed" to and you will > get the emails from that. Understood, thanks. Hopefully the other maintainers will be as on the ball as you are. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-21 7:56 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones 2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones 2021-05-20 16:41 ` Jarkko Sakkinen 2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones 2021-05-20 16:43 ` Jarkko Sakkinen 2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann 2021-05-21 7:22 ` Lee Jones 2021-05-21 7:42 ` Greg Kroah-Hartman 2021-05-21 7:44 ` Greg Kroah-Hartman 2021-05-21 7:56 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).