From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575EAC47089 for ; Thu, 27 May 2021 16:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29E9C613C0 for ; Thu, 27 May 2021 16:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234756AbhE0QNe (ORCPT ); Thu, 27 May 2021 12:13:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235148AbhE0QNc (ORCPT ); Thu, 27 May 2021 12:13:32 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42725C061574 for ; Thu, 27 May 2021 09:11:59 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id 76so1136852qkn.13 for ; Thu, 27 May 2021 09:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1DCYsxPcwgz6wGBXKddPfgeFqjOqmPMV5wFOCxRJ+3A=; b=PngmZ1AInSHpKNoMvNBtIfyeQ/6Llk/gXeRI9Pd0xGn54rwNOD/XdwequEEpKUbM53 6VlYrgeQs1Wi1y9TNmxlBivIkc8Si+ODQGVBXt+Ie0XI6nBRrOqUSTLPB2U83Sk0pWju 4Rzy6Q6+G5uqk1pkzlP2nb9SxHeLPmPRRS2IsmZT/Yg/cCbcMzATIstA5PS9jp/YNwFb kfvokaxjIB6487ZnmGgCD2xOLe54oPJmjKTpqFjrBnf6WMAhBE3kXD7F6XmsGPQlXIik VmLapHyeddMc5C2ybH8Jcd/IrWAI3N8u6eOXcKxlYY1qIaFgqRT/MiFqZQmMOGuJWA9U zGzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1DCYsxPcwgz6wGBXKddPfgeFqjOqmPMV5wFOCxRJ+3A=; b=KWUH0n5KRffMa8xjolQfRzkMb5Xll0RwizRizySqA/paU2fRoWhgFuJfHXnsd/prRw z/ALfdF3e9PWDHER1LVV6T1e/ZYrAVkVossAtk2IhS21lkhs33PjjU744LpwS9jxCe/k 5yyihSRiA+A/4NzVmhUSL4x9uzCBf8wj6E5Iq5V+Cf9NV+Z2RjIMQ9V/GD9VqHGt1CPP 8EM2LVK2PxjqJipJ5jn3p5Pvi7tswOWttYrtHOTYBwGbuOXcO/tC1Z3zFa40XIoWICs3 5DaYV4gdwJt6PWpLcTx76SP0EkqXtJZ5onS6xi1ekq4w9PIZCWzpTnkvDlAw9G9blsoL HyCQ== X-Gm-Message-State: AOAM533vXtUxhpijUncfQEnPMJcPnxwVGEoBBwtqhnpUO4wPgLA2fwQv 6uhxTP4W1MzBBrQ1XwnhR/b+ew== X-Google-Smtp-Source: ABdhPJxSGGCq2RcvTVfyqdH4MeLuYORIVug/LGCAqFWth8scx61JtGxD+Zd0VUKM5Xo7RbDMK1wHOQ== X-Received: by 2002:a37:6645:: with SMTP id a66mr4272666qkc.314.1622131918489; Thu, 27 May 2021 09:11:58 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id x9sm1587665qto.33.2021.05.27.09.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 09:11:57 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lmIc0-00Fc4q-Ni; Thu, 27 May 2021 13:11:56 -0300 Date: Thu, 27 May 2021 13:11:56 -0300 From: Jason Gunthorpe To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Alexander Wellbrock , Jarkko Sakkinen , Peter Huewe , Peter Robinson , linux-integrity@vger.kernel.org Subject: Re: [PATCH] tpm_tis_spi: add missing SPI device ID entries Message-ID: <20210527161156.GH1096940@ziepe.ca> References: <20210527152352.3835076-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527152352.3835076-1-javierm@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, May 27, 2021 at 05:23:52PM +0200, Javier Martinez Canillas wrote: > The SPI core always reports a "MODALIAS=spi:", even if the device was > registered via OF. This means that this module won't auto-load if a DT has > for example has a node with a compatible "infineon,slb9670" string. Really? Then why do we have of_tis_spi_match and why does spi have an of_match_table? Jason