From: Jarkko Sakkinen <jarkko@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>,
Matthew Garrett <mjg59@google.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: Recent tpm_tis IRQ handling changes are causing kernel backtraces
Date: Tue, 1 Jun 2021 21:02:26 +0300 [thread overview]
Message-ID: <20210601180226.ioql2j5o2y2cm3ap@kernel.org> (raw)
In-Reply-To: <df7bcbfa-1706-1b8f-f32e-01c2d5e4ac7c@redhat.com>
On Mon, May 31, 2021 at 10:24:05AM +0200, Hans de Goede wrote:
> Hi,
>
> On 5/31/21 6:36 AM, Jarkko Sakkinen wrote:
> > On Thu, May 27, 2021 at 05:27:49PM +0200, Hans de Goede wrote:
> >> This is from:
> >> https://retrace.fedoraproject.org/faf/reports/74723/ (public)
> >
> > I wonder if this occurs only with O_NONBLOCK.
> >
> > Any chances to get the output of
> >
> > sudo tools/testing/selftests/tpm2/test_smoke.sh
> >
> > ?
> >
> > It's obvious that there is some sort of bug, but it's not yet obvious that
> > this bug is connected to the locality issue yet, as in this case locality
> > is successfully reserved by tpm_try_get_ops() in tpm_dev_async_work()
> > (driver/chars/tpm/tpm-dev-common.c).
>
> As mentioned I've asked the user to try with tpm_tis.interrupts=0 and see
> if that makes a difference. I got a reply that the user only hit this
> once and that this is not (easily) reproducible :|
This is not about interrupts. It's about opening the file with O_NONBLOCK.
I.e. the function returns and defers sending the command.
> "looks like a spurious problem that may already be solved."
>
> I did get permission to open up the bug (make it public) so if you want
> more info it is probably easiest if you interact directly with the
> reporter here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1964974
>
> If you don't already have a bugzilla.redhat.com account, creating one
> is super easy, you only need to enter your email address and pick a
> password.
I'll create one. I don't actually remember if I have one or not :-)
/Jarkko
next prev parent reply other threads:[~2021-06-01 18:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 13:09 Recent tpm_tis IRQ handling changes are causing kernel backtraces Hans de Goede
2021-03-16 15:34 ` Hans de Goede
2021-03-16 19:18 ` Jarkko Sakkinen
2021-05-08 9:07 ` Hans de Goede
2021-05-10 17:25 ` Jarkko Sakkinen
2021-05-11 8:37 ` Hans de Goede
2021-05-11 23:48 ` Jarkko Sakkinen
2021-05-26 19:03 ` Hans de Goede
2021-05-27 14:00 ` Jarkko Sakkinen
2021-05-27 15:27 ` Hans de Goede
[not found] ` <20210531043616.u3v25qzkkrik5apq@kernel.org>
2021-05-31 8:24 ` Hans de Goede
2021-06-01 18:02 ` Jarkko Sakkinen [this message]
2021-06-01 16:04 ` Hans de Goede
2021-06-01 18:03 ` Jarkko Sakkinen
2021-06-14 13:33 ` Hans de Goede
2021-06-15 13:01 ` Jarkko Sakkinen
2021-06-15 13:59 ` Hans de Goede
2021-06-23 13:37 ` Jarkko Sakkinen
2021-06-21 12:04 ` Hans de Goede
2021-06-23 13:40 ` Jarkko Sakkinen
2021-06-23 13:54 ` Hans de Goede
2021-06-29 18:04 ` Recent tpm_tis IRQ handling changes are causing kernel backtraces] Jarkko Sakkinen
2021-06-29 19:14 ` Hans de Goede
2021-06-29 22:05 ` Jarkko Sakkinen
2021-06-30 12:47 ` Hans de Goede
2021-06-30 13:36 ` Hans de Goede
2021-07-09 18:44 ` Jarkko Sakkinen
2021-07-17 16:10 ` Hans de Goede
2021-07-27 2:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601180226.ioql2j5o2y2cm3ap@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hdegoede@redhat.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).