linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	linux-integrity <linux-integrity@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tpm_tis: Use DEFINE_RES_MEM() to simplify code
Date: Thu, 3 Jun 2021 08:29:54 +0300	[thread overview]
Message-ID: <20210603052954.ms7s4cmkejpxo2lc@kernel.org> (raw)
In-Reply-To: <277d929b-0602-ffbb-5866-64731a19ff14@huawei.com>

On Wed, Jun 02, 2021 at 09:11:47AM +0800, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/6/2 1:57, Jarkko Sakkinen wrote:
> > On Tue, Jun 01, 2021 at 02:45:07PM +0800, Zhen Lei wrote:
> >> No functional change.
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> > 
> > No change, no need to apply?
> 
> But it can make the code look simpler, easier to read and maintain(The start
> address does not need to appear twice). I think that's why these DEFINE_RES_*
> macros are defined.
> 
> By the way, would it be better to change the letters in 0xFED40000 to lowercase?

I mean "No functional change" does not really tell anything about anything.

Please just describe what the commit does.

/Jarkko

> 
> > 
> > /Jarkko
> > 
> >> ---
> >>  drivers/char/tpm/tpm_tis.c | 6 +-----
> >>  1 file changed, 1 insertion(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> >> index 4ed6e660273a414..d3f2e5364c275f4 100644
> >> --- a/drivers/char/tpm/tpm_tis.c
> >> +++ b/drivers/char/tpm/tpm_tis.c
> >> @@ -363,11 +363,7 @@ static int tpm_tis_force_device(void)
> >>  {
> >>  	struct platform_device *pdev;
> >>  	static const struct resource x86_resources[] = {
> >> -		{
> >> -			.start = 0xFED40000,
> >> -			.end = 0xFED40000 + TIS_MEM_LEN - 1,
> >> -			.flags = IORESOURCE_MEM,
> >> -		},
> >> +		DEFINE_RES_MEM(0xFED40000, TIS_MEM_LEN)
> >>  	};
> >>  
> >>  	if (!force)
> >> -- 
> >> 2.26.0.106.g9fadedd
> >>
> >>
> >>
> > 
> > .
> > 
> 
> 

  reply	other threads:[~2021-06-03  5:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  6:45 [PATCH 1/1] tpm_tis: Use DEFINE_RES_MEM() to simplify code Zhen Lei
2021-06-01 17:57 ` Jarkko Sakkinen
2021-06-02  1:11   ` Leizhen (ThunderTown)
2021-06-03  5:29     ` Jarkko Sakkinen [this message]
2021-06-03  6:27       ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603052954.ms7s4cmkejpxo2lc@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).