From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00086C48BD1 for ; Thu, 10 Jun 2021 07:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBC70613C8 for ; Thu, 10 Jun 2021 07:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbhFJHvs (ORCPT ); Thu, 10 Jun 2021 03:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbhFJHvs (ORCPT ); Thu, 10 Jun 2021 03:51:48 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B09C061574 for ; Thu, 10 Jun 2021 00:49:52 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id n17so3559444ljg.2 for ; Thu, 10 Jun 2021 00:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9U6TcdGqm3u7Y2Gu0vtl5OMZBJyJdaAvj/22UF0aYUY=; b=m6h2sCmVnvQGmh62QuSQtgdkFEfB2vCjhZyS/lQSoaS1c1pBGTdiOrA5UOKHG7s+Sw z8vR75Zkxz1UnCNTBSlFmL9+m09W4aGfLenkDWyhatb9ZLrEWNpEqAuIqI7CAqckZWmW xSIlS6ZsP7xRrE5/aacBrCjBsI2Lvtc49J8Xwe0zo5wq8l9plYmELtoYbsjTrBgEx2yV ZwzIiQ/hfz4V9xt5nGRPtyw7bbAG/9Ft+KJNSgCox42XMvFg1SW++nTWQCo2IG06IoAV JEuZF0zqmWC0rcoKKCG+mGzMIBk4YLRQasqjVNoD1zgEZwZads2frxgD87USr0u5m88I S+mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9U6TcdGqm3u7Y2Gu0vtl5OMZBJyJdaAvj/22UF0aYUY=; b=VyDLrmHD6LWdDlFC4w5vDd3PVaYkDlaKfrlkjUGJom7Mffrc1qorkOizcbs6BbMIGr 7+BPFZCjSf86BRqD2bFNZARQyd0AevIGTW04PY9HNQMd5NDpM/HPPsh5dOIdD7MccjUf 99LUj/AwGZkez3huhCDsxTa7xyP4aNDaDf6YdJoOvWt76GKVMDMxHRePTxlsNSSz2sD5 rFQs+wxqXv0uG3KP+5scWTMMpkWg5IrMrm1slneAL1Be/AsHsA91YQxvSKHGhlUgtNRk OcyQaSCRy0UQcyfnEGvV6JPMjY8DGFM7PH9rRAV53GTYw+QBjulud5ZgrxDtn0v8l7rL k3aQ== X-Gm-Message-State: AOAM530a1M/PzdJtBFsl7DKXMzxzxdFDhcmF4WRVXd8tXwv0tHWAYG5V RiBj6/SBzGelRy8JAypClxtZAw== X-Google-Smtp-Source: ABdhPJw+LWHmePKtC4iF5BWtQ+R4/B9mNUcolpBZmJXquUlETwTjG1GUUJVdPdt3rnw/U2h9mcjuvg== X-Received: by 2002:a2e:6c12:: with SMTP id h18mr1189990ljc.125.1623311390816; Thu, 10 Jun 2021 00:49:50 -0700 (PDT) Received: from jade (h-79-136-85-3.A175.priv.bahnhof.se. [79.136.85.3]) by smtp.gmail.com with ESMTPSA id b2sm220213lfo.221.2021.06.10.00.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 00:49:50 -0700 (PDT) Date: Thu, 10 Jun 2021 09:49:48 +0200 From: Jens Wiklander To: Tyler Hicks Cc: Sumit Garg , Rijo-john.Thomas@amd.com, Allen Pais , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Vikas Gupta , Thirupathaiah Annapureddy , Pavel Tatashin , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , op-tee@lists.trustedfirmware.org, linux-integrity , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing Message-ID: <20210610074948.GC2753553@jade> References: <20210609002326.210024-1-tyhicks@linux.microsoft.com> <20210609002326.210024-6-tyhicks@linux.microsoft.com> <20210609054621.GB4910@sequoia> <20210609121533.GA2267052@jade> <20210609134225.GC4910@sequoia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210609134225.GC4910@sequoia> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Jun 09, 2021 at 08:42:25AM -0500, Tyler Hicks wrote: [snip] > > I've just posted "[PATCH 0/7] tee: shared memory updates", > > https://lore.kernel.org/lkml/20210609102324.2222332-1-jens.wiklander@linaro.org/ > > > > Where tee_shm_alloc() is replaced by among other functions > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the > > problem with TEE_SHM_DMA_BUF. > > Thanks! At first glance, that series would take care of the last three > patches in my kexec/kdump series. > > I'm a bit worried that it is a rewrite of the shm allocator. Do you plan > to send all of that to stable? (I mentioned earlier in this thread that > I'm affected by these bugs in linux-5.4.y.) No, that might be a bit much. > Also, you and Sumit don't seem to have the same opinion on kernel > drivers making use of tee_shm_register() for allocations that are only > used internally. Can you comment on that? > > I'm not clear on the next steps for fixing these kexec/kdump bugs in > older releases. I appreciate any guidance here. Neither am I be honest. You're the only one that has brought up this problem so perhaps it's enough to focus on the stable branch you need to have fixed. If I've understood it correctly it's best if it's possible to cherry-pick the fixes from mainline to the stable branch in question. So we must make sure to get your needed patches in before any rewrites that would make cherry-picking impossible. The rewrite I'm proposing isn't urgent so it can be held off for a while. Cheers, Jens