From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE47C4743C for ; Wed, 23 Jun 2021 13:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FEEF61076 for ; Wed, 23 Jun 2021 13:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbhFWNjj (ORCPT ); Wed, 23 Jun 2021 09:39:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:45338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbhFWNji (ORCPT ); Wed, 23 Jun 2021 09:39:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E68161026; Wed, 23 Jun 2021 13:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624455441; bh=o13BLkIuAdCLBHRUNOjVa6U6bQqdEabC6D/LrfUdVjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FNMasFuLBXIa4kpnnxIxZ5WDPh0RCCQoGDJdcuvH5Mi4GUIibvUbEBtq12lYNyIpe b0PfHskalbJEE+BXwj4N/J9dMWKyK2dOnpYT2BPsrKcTZ8UEH7QfJIeZUCo7GXEbCk m7SIwTCKg8g6dsh5huVXwknGLzBmz+rgVtR5Xje0CLsqEGoptH94HiE4lRHSw1lW7S fIjpqGyb9zfU86M+ZkWM7k5ZM2Img4YtOWs1uRqvLYhfp9hDG427myjxv2NV757Ian WhTih/bmUrN7Co7WfZY9RHln8Lm06aPPNFxky4sos0WlxEKI0bQcQvL0ewWKow39bD facsZDUPUIO0Q== Date: Wed, 23 Jun 2021 16:37:19 +0300 From: Jarkko Sakkinen To: Hans de Goede Cc: Jerry Snitselaar , Matthew Garrett , linux-integrity , James Bottomley Subject: Re: Recent tpm_tis IRQ handling changes are causing kernel backtraces Message-ID: <20210623133719.5lwycyei422yfmgq@kernel.org> References: <4f525bca-3836-7f5c-7913-e54d620473aa@redhat.com> <81aa6340-f854-8f26-f599-03b116cc3c29@redhat.com> <20210527140025.vl3ply6wnn7rsygg@kernel.org> <27d71b81-1e89-1b5d-ddaf-a8928bac90fd@redhat.com> <20210531043616.u3v25qzkkrik5apq@kernel.org> <89d5b891-97d8-caed-4eb1-6d4d485a2fd1@redhat.com> <5680899e-9040-7641-e6ac-23edd2d988cf@redhat.com> <20210615130103.sln2s6hq4fkufi5a@kernel.org> <62da92c6-b54e-379e-216c-be0b8eec82f0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62da92c6-b54e-379e-216c-be0b8eec82f0@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, Jun 15, 2021 at 03:59:06PM +0200, Hans de Goede wrote: > Hi, > > On 6/15/21 3:01 PM, Jarkko Sakkinen wrote: > > On Mon, Jun 14, 2021 at 03:33:33PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 6/1/21 6:04 PM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 5/31/21 6:36 AM, Jarkko Sakkinen wrote: > >>>>> Interestingly enough the first backtrace is also happening on a: > >>>>> "Dell Inc. XPS 13 9310/0MRT12, BIOS 2.2.0 04/06/2021" > >>>>> > >>>>> So it seems that at least with 5.12.6 (which has the last 2 fixes) > >>>>> all reports are about the XPS 13 9310. I wonder if there is an > >>>>> issue with the TPM interrupt line on the XPS 13 9310; I've asked the > >>>>> reporters to try adding tpm_tis.interrupts=0 to their kernel commandline. > >>>> > >>>> This is helpful for sure that these all are happening on matching hardware. > >>> > >>> So our kernel-backtrace tracking info (ABRT) just recorded a third backtrace > >>> with a kernel >= 5.12.6, again on the XPS 13 9310, so now we have 3 variants: > >>> > >>> 1. Backtrace starting with a call to ima_add_boot_aggregate > >>> https://bugzilla.redhat.com/show_bug.cgi?id=1963712 > >>> > >>> 2. Backtrace starting with a call to tpm_dev_async_work: > >>> https://bugzilla.redhat.com/show_bug.cgi?id=1964974 > >>> (note this one is not easily reproducible) > >>> > >>> 3. Backtrace starting with a call to rng_dev_read: > >>> https://bugzilla.redhat.com/show_bug.cgi?id=1920510 > >>> > >>> 3. is the new one. All bugs linked above are public, all 3 backtraces > >>> so far have only been reported on the XPS 13 9310 (with kernel >= 5.12.6) > >>> and I've asked all the reporters to check if tpm_tis.interrupts=0 helps. > >> > >> Quick status update, I've got a response from a XPS 13 9310 user in: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=1920510 > >> > >> Indicating that a. he can reproduce this with the latest >= 5.12.6 kernels; > >> and b. it goes away when specifying tpm_tis.interrupts=0 as I expected > >> (I expected this because all the bug-reports started when the interrupt > >> code got fixed/re-enabled a while ago). > >> > >> Si I think that there just is something broken wrt the interrupt setup > >> on the XPS 13 9310 and that we should probably add an antry for the > >> XPS 13 9310 to the already existing tpm_tis_dmi_table pointing to the > >> also already existing tpm_tis_disable_irq callback. > >> > >> If other people agree that that is probably the best way forward ? > >> then I can prepare a patch and ask the user to test this. > >> > >> Regards, > >> > >> Hans > > > > I think it all roots down to the use of TPM before tpm2_probe(), i.e. > > TPM is not in expected state when tpm_chip_start() is called. I > > suggested to try out adding tpm_chip_stop() right before > > tpm_chip_start() in another response. > > > > That's only thing that makes logically sense to me at least. > > Shouldn't there the be some completion somewhere with get completed > at the end of probe(), with the read-path which is involved in this > case blocking on this? > > If you can prepare a kernel-patch to test, then I can build a Fedora > kernel rpm with the patch added for the user to test. > > Regards, > > Hans After rc1 PR I'll have to check through the hardware that I have if something would reproduce the issue locally. This is too blind shooting ATM. /Jarkko