From: Stefan Berger <stefanb@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: zohar@linux.ibm.com, Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH ima-evm-utils 3/3] libimaevm: Remove calculation of a digest over a symbolic link
Date: Wed, 30 Jun 2021 15:33:03 -0400 [thread overview]
Message-ID: <20210630193303.2531284-4-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20210630193303.2531284-1-stefanb@linux.ibm.com>
Signature verification on symbolic links is not supported by IMA in the
kernel, so remove the calculation of digests over symbolic links.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
src/libimaevm.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/src/libimaevm.c b/src/libimaevm.c
index 07a25c9..6591d20 100644
--- a/src/libimaevm.c
+++ b/src/libimaevm.c
@@ -177,20 +177,6 @@ out:
return err;
}
-static int add_link_hash(const char *path, EVP_MD_CTX *ctx)
-{
- int len;
- char buf[1024];
-
- len = readlink(path, buf, sizeof(buf));
- /* 0-length links are also an error */
- if (len <= 0)
- return -1;
-
- log_info("link: %s -> %.*s\n", path, len, buf);
- return !EVP_DigestUpdate(ctx, buf, len);
-}
-
int ima_calc_hash(const char *file, uint8_t *hash)
{
const EVP_MD *md;
@@ -231,9 +217,6 @@ int ima_calc_hash(const char *file, uint8_t *hash)
case S_IFREG:
err = add_file_hash(file, pctx);
break;
- case S_IFLNK:
- err = add_link_hash(file, pctx);
- break;
default:
log_err("Unsupported file type (0x%x)", st.st_mode & S_IFMT);
err = -1;
--
2.31.1
next prev parent reply other threads:[~2021-06-30 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 19:33 [PATCH ima-evm-utils 0/3] libimaevm: Remove digest calculations not supported by IMA Stefan Berger
2021-06-30 19:33 ` [PATCH ima-evm-utils 1/3] libimaevm: Remove calculation of a digest over a device file Stefan Berger
2021-06-30 19:33 ` [PATCH ima-evm-utils 2/3] libimaevm: Remove calculation of a digest over a directory Stefan Berger
2021-06-30 19:33 ` Stefan Berger [this message]
2021-07-06 18:52 ` [PATCH ima-evm-utils 0/3] libimaevm: Remove digest calculations not supported by IMA Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630193303.2531284-4-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).