From: Patrick Uiterwijk <patrick@puiterwijk.org>
To: linux-integrity@vger.kernel.org, zohar@linux.ibm.com
Cc: pbrobinson@redhat.com, patrick@puiterwijk.org
Subject: [PATCH ima-evm-utils v2 0/2] Fix use of sign_hash via API
Date: Mon, 5 Jul 2021 17:49:48 +0200 [thread overview]
Message-ID: <20210705154950.497359-1-patrick@puiterwijk.org> (raw)
In-Reply-To: <20210106094335.3178261-1-patrick@puiterwijk.org>
When using sign_hash, the resulting signature is incorrect if any hash
algorithm other than sha1 is used.
This is because while the sign_hash function has a hashalgo argument,
the sign_hash_v2 function does not actually use this argument for
anything except setting the hash_algo value in the header.
This patch makes sure it uses the algo variable consistently.
Changes since v1:
- Using sys/xattr.h
- Removed copyright line for sign_ima
Patrick Uiterwijk (2):
Fix sign_hash not observing the hashalgo argument
Add test for using sign_hash API
src/evmctl.c | 23 ----------------
src/libimaevm.c | 4 +--
src/utils.c | 20 ++++++++++++++
src/utils.h | 1 +
tests/.gitignore | 2 ++
tests/Makefile.am | 5 ++++
tests/sign_verify.apitest.c | 55 +++++++++++++++++++++++++++++++++++++
tests/sign_verify.test | 30 ++++++++++++++++----
8 files changed, 109 insertions(+), 31 deletions(-)
create mode 100644 tests/sign_verify.apitest.c
--
2.31.1
next prev parent reply other threads:[~2021-07-05 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 9:43 [PATCH 0/2] ima-evm-utils: " Patrick Uiterwijk
2021-01-06 9:43 ` [PATCH 1/2] Fix sign_hash not observing the hashalgo argument Patrick Uiterwijk
2021-01-07 12:24 ` Mimi Zohar
2021-01-07 13:08 ` Vitaly Chikunov
2021-01-07 13:15 ` Vitaly Chikunov
2021-01-07 14:55 ` Mimi Zohar
2021-01-07 15:13 ` Patrick Uiterwijk
2021-01-06 9:43 ` [PATCH 2/2] Add test for using sign_hash API Patrick Uiterwijk
2021-01-07 12:25 ` Mimi Zohar
2021-01-07 12:53 ` Vitaly Chikunov
2021-01-07 15:08 ` Patrick Uiterwijk
2021-07-05 15:49 ` Patrick Uiterwijk [this message]
2021-07-05 15:49 ` [PATCH ima-evm-utils v2 1/2] Fix sign_hash not observing the hashalgo argument Patrick Uiterwijk
2021-07-05 15:49 ` [PATCH ima-evm-utils v2 2/2] Add test for using sign_hash API Patrick Uiterwijk
2021-07-06 15:53 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705154950.497359-1-patrick@puiterwijk.org \
--to=patrick@puiterwijk.org \
--cc=linux-integrity@vger.kernel.org \
--cc=pbrobinson@redhat.com \
--cc=zohar@linux.ibm.com \
--subject='Re: [PATCH ima-evm-utils v2 0/2] Fix use of sign_hash via API' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).