From: kernel test robot <lkp@intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
zohar@linux.ibm.com, serge@hallyn.com,
christian.brauner@ubuntu.com, containers@lists.linux.dev,
dmitry.kasatkin@gmail.com, ebiederm@xmission.com,
krzysztof.struczynski@huawei.com, roberto.sassu@huawei.com,
mpeters@redhat.com
Subject: Re: [PATCH v7 14/14] ima: Setup securityfs for IMA namespace
Date: Thu, 16 Dec 2021 20:02:05 +0800 [thread overview]
Message-ID: <202112161948.NK58RGVT-lkp@intel.com> (raw)
In-Reply-To: <20211216054323.1707384-15-stefanb@linux.vnet.ibm.com>
Hi Stefan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on zohar-integrity/next-integrity]
[also build test WARNING on linux/master linus/master v5.16-rc5]
[cannot apply to jmorris-security/next-testing next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211216-134611
base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: mips-buildonly-randconfig-r006-20211216 (https://download.01.org/0day-ci/archive/20211216/202112161948.NK58RGVT-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245bab9fbb364faa1581e4f92ba3119a872fba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/bc2f1f683efbf2ad7b955fd4afc78861609eff4b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211216-134611
git checkout bc2f1f683efbf2ad7b955fd4afc78861609eff4b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash security/integrity/ima/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> security/integrity/ima/ima_fs.c:451:5: warning: no previous prototype for function 'ima_fs_ns_init' [-Wmissing-prototypes]
int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root)
^
security/integrity/ima/ima_fs.c:451:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root)
^
static
1 warning generated.
vim +/ima_fs_ns_init +451 security/integrity/ima/ima_fs.c
450
> 451 int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root)
452 {
453 struct ima_namespace *ns = user_ns->ima_ns;
454 struct dentry *int_dir;
455 struct dentry *ima_dir = NULL;
456 struct dentry *ima_symlink = NULL;
457 struct dentry *binary_runtime_measurements = NULL;
458 struct dentry *ascii_runtime_measurements = NULL;
459 struct dentry *runtime_measurements_count = NULL;
460 struct dentry *violations = NULL;
461
462 /* FIXME: update when evm and integrity are namespaced */
463 if (user_ns != &init_user_ns) {
464 int_dir =
465 securityfs_create_dir("integrity", root);
466 if (IS_ERR(int_dir))
467 return -1;
468 } else
469 int_dir = integrity_dir;
470
471 ima_dir = securityfs_create_dir("ima", int_dir);
472 if (IS_ERR(ima_dir))
473 goto out;
474
475 ima_symlink = securityfs_create_symlink("ima", root, "integrity/ima",
476 NULL);
477 if (IS_ERR(ima_symlink))
478 goto out;
479
480 binary_runtime_measurements =
481 securityfs_create_file("binary_runtime_measurements",
482 S_IRUSR | S_IRGRP, ima_dir, NULL,
483 &ima_measurements_ops);
484 if (IS_ERR(binary_runtime_measurements))
485 goto out;
486
487 ascii_runtime_measurements =
488 securityfs_create_file("ascii_runtime_measurements",
489 S_IRUSR | S_IRGRP, ima_dir, NULL,
490 &ima_ascii_measurements_ops);
491 if (IS_ERR(ascii_runtime_measurements))
492 goto out;
493
494 runtime_measurements_count =
495 securityfs_create_file("runtime_measurements_count",
496 S_IRUSR | S_IRGRP, ima_dir, NULL,
497 &ima_measurements_count_ops);
498 if (IS_ERR(runtime_measurements_count))
499 goto out;
500
501 violations =
502 securityfs_create_file("violations", S_IRUSR | S_IRGRP,
503 ima_dir, NULL, &ima_htable_violations_ops);
504 if (IS_ERR(violations))
505 goto out;
506
507
508 if (!ns->policy_dentry_removed) {
509 ns->policy_dentry =
510 securityfs_create_file("policy", POLICY_FILE_FLAGS,
511 ima_dir, NULL,
512 &ima_measure_policy_ops);
513 if (IS_ERR(ns->policy_dentry))
514 goto out;
515 }
516
517 return 0;
518 out:
519 securityfs_remove(ns->policy_dentry);
520 securityfs_remove(violations);
521 securityfs_remove(runtime_measurements_count);
522 securityfs_remove(ascii_runtime_measurements);
523 securityfs_remove(binary_runtime_measurements);
524 securityfs_remove(ima_symlink);
525 securityfs_remove(ima_dir);
526 if (user_ns != &init_user_ns)
527 securityfs_remove(integrity_dir);
528
529 return -1;
530 }
531
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-12-16 12:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 5:43 [PATCH v7 00/14] ima: Namespace IMA with audit support in IMA-ns Stefan Berger
2021-12-16 5:43 ` [PATCH v7 01/14] ima: Add IMA namespace support Stefan Berger
2021-12-16 14:08 ` Christian Brauner
2021-12-16 21:52 ` James Bottomley
2021-12-17 9:55 ` Christian Brauner
2021-12-16 5:43 ` [PATCH v7 02/14] ima: Define ns_status for storing namespaced iint data Stefan Berger
2021-12-16 5:43 ` [PATCH v7 03/14] ima: Namespace audit status flags Stefan Berger
2021-12-16 5:43 ` [PATCH v7 04/14] ima: Move policy related variables into ima_namespace Stefan Berger
2021-12-16 14:26 ` kernel test robot
2021-12-16 5:43 ` [PATCH v7 05/14] ima: Move ima_htable " Stefan Berger
2021-12-16 5:43 ` [PATCH v7 06/14] ima: Move measurement list related variables " Stefan Berger
2021-12-16 5:43 ` [PATCH v7 07/14] ima: Only accept AUDIT rules for IMA non-init_ima_ns namespaces for now Stefan Berger
2021-12-16 5:43 ` [PATCH v7 08/14] ima: Implement hierarchical processing of file accesses Stefan Berger
2021-12-16 5:43 ` [PATCH v7 09/14] securityfs: Only use simple_pin_fs/simple_release_fs for init_user_ns Stefan Berger
2021-12-16 5:43 ` [PATCH v7 10/14] securityfs: Extend securityfs with namespacing support Stefan Berger
2021-12-16 13:40 ` Christian Brauner
2021-12-16 16:28 ` Christian Brauner
2022-01-03 14:09 ` Stefan Berger
2021-12-17 16:21 ` [RFC PATCH] securityfs: securityfs_dir_inode_operations can be static kernel test robot
2021-12-17 16:29 ` [PATCH v7 10/14] securityfs: Extend securityfs with namespacing support kernel test robot
2021-12-16 5:43 ` [PATCH v7 11/14] ima: Move some IMA policy and filesystem related variables into ima_namespace Stefan Berger
2021-12-16 5:43 ` [PATCH v7 12/14] ima: Use mac_admin_ns_capable() to check corresponding capability Stefan Berger
2021-12-16 5:43 ` [PATCH v7 13/14] ima: Move dentry into ima_namespace and others onto stack Stefan Berger
2021-12-16 5:43 ` [PATCH v7 14/14] ima: Setup securityfs for IMA namespace Stefan Berger
2021-12-16 10:59 ` kernel test robot
2021-12-16 12:02 ` kernel test robot [this message]
2021-12-16 13:51 ` Christian Brauner
2021-12-16 21:38 ` Stefan Berger
2021-12-16 12:50 ` [PATCH v7 00/14] ima: Namespace IMA with audit support in IMA-ns Christian Brauner
2021-12-16 13:31 ` Christian Brauner
2021-12-16 21:27 ` Stefan Berger
2021-12-17 10:25 ` Christian Brauner
2021-12-18 2:38 ` Stefan Berger
2021-12-16 21:00 ` Stefan Berger
2021-12-17 10:06 ` Christian Brauner
2021-12-27 17:29 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112161948.NK58RGVT-lkp@intel.com \
--to=lkp@intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux.dev \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.struczynski@huawei.com \
--cc=linux-integrity@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mpeters@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).