From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Roberto Sassu <roberto.sassu@huawei.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: <viro@zeniv.linux.org.uk>,
<linux-security-module@vger.kernel.org>,
<linux-integrity@vger.kernel.org>, <initramfs@vger.kernel.org>,
<linux-api@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bug-cpio@gnu.org>,
<silviu.vlasceanu@huawei.com>, <dmitry.kasatkin@huawei.com>,
<takondra@cisco.com>, <kamensky@cisco.com>, <hpa@zytor.com>,
<arnd@arndb.de>, <rob@landley.net>, <james.w.mcmechan@gmail.com>,
<niveditas98@gmail.com>, Dirk Behme <dirk.behme@de.bosch.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v4 1/3] initramfs: add file metadata
Date: Wed, 15 Jun 2022 19:54:12 +0200 [thread overview]
Message-ID: <20220615175412.GA7029@lxhi-065> (raw)
In-Reply-To: <20190523121803.21638-2-roberto.sassu@huawei.com>
Hello Roberto,
Hello Mimi,
On Thu, May 23, 2019 at 02:18:01PM +0200, Roberto Sassu wrote:
> From: Mimi Zohar <zohar@linux.vnet.ibm.com>
>
> This patch adds metadata to a file from a supplied buffer. The buffer might
> contains multiple metadata records. The format of each record is:
>
> <metadata len (ASCII, 8 chars)><version><type><metadata>
>
> For now, only the TYPE_XATTR metadata type is supported. The specific
> format of this metadata type is:
>
> <xattr #N name>\0<xattr #N value>
>
> [kamensky: fixed restoring of xattrs for symbolic links by using
> sys_lsetxattr() instead of sys_setxattr()]
>
> [sassu: removed state management, kept only do_setxattrs(), added support
> for generic file metadata, replaced sys_lsetxattr() with
> vfs_setxattr(), added check for entry_size, added check for
> hdr->c_size, replaced strlen() with strnlen(); moved do_setxattrs()
> before do_name()]
>
> Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Signed-off-by: Victor Kamensky <kamensky@cisco.com>
> Signed-off-by: Taras Kondratiuk <takondra@cisco.com>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
> include/linux/initramfs.h | 21 ++++++++++
> init/initramfs.c | 88 ++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 107 insertions(+), 2 deletions(-)
> create mode 100644 include/linux/initramfs.h
[..]
> +static int __init do_setxattrs(char *pathname, char *buf, size_t size)
> +{
> + struct path path;
> + char *xattr_name, *xattr_value;
> + size_t xattr_name_size, xattr_value_size;
> + int ret;
> +
> + xattr_name = buf;
> + xattr_name_size = strnlen(xattr_name, size);
> + if (xattr_name_size == size) {
> + error("malformed xattrs");
> + return -EINVAL;
> + }
> +
[..]
> +
> + switch (hdr->c_type) {
> + case TYPE_XATTR:
> + do_setxattrs(pathname, buf + sizeof(*hdr),
> + entry_size - sizeof(*hdr));
Is it on purpose not to check the return value of do_setxattrs?
I think I would have more comfort and piece of mind if I knew
the return value is properly checked and acted upon. Otherwise,
why returning an int from within do_setxattrs() at all?
BR, Eugeniu
next prev parent reply other threads:[~2022-06-15 17:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 12:18 [PATCH v4 0/3] initramfs: add support for xattrs in the initial ram disk Roberto Sassu
2019-05-23 12:18 ` [PATCH v4 1/3] initramfs: add file metadata Roberto Sassu
2022-06-15 17:54 ` Eugeniu Rosca [this message]
2019-05-23 12:18 ` [PATCH v4 2/3] initramfs: read metadata from special file METADATA!!! Roberto Sassu
2019-07-01 12:54 ` Mimi Zohar
2019-05-23 12:18 ` [PATCH v4 3/3] gen_init_cpio: add support for file metadata Roberto Sassu
2019-06-30 15:27 ` Mimi Zohar
2022-06-16 14:47 ` Eugeniu Rosca
2022-06-16 15:16 ` Eugeniu Rosca
2022-06-30 15:06 ` Roberto Sassu
2022-06-30 20:38 ` Eugeniu Rosca
2019-06-03 9:31 ` [PATCH v4 0/3] initramfs: add support for xattrs in the initial ram disk Roberto Sassu
2019-06-03 18:32 ` Rob Landley
2019-06-26 8:15 ` Roberto Sassu
2019-06-30 15:39 ` Mimi Zohar
2019-07-01 13:42 ` Roberto Sassu
2019-07-01 14:31 ` Mimi Zohar
2019-07-15 16:54 ` Roberto Sassu
2019-07-24 15:34 ` Roberto Sassu
2022-06-09 10:26 ` Eugeniu Rosca
2022-06-09 11:05 ` Roberto Sassu
2022-06-10 15:33 ` Eugeniu Rosca
2022-06-10 15:38 ` Roberto Sassu
2022-06-15 9:27 ` Eugeniu Rosca
2022-07-18 16:36 ` Jim Baxter
2022-07-18 16:49 ` Roberto Sassu
2022-07-18 18:08 ` Jim Baxter
2022-07-19 6:55 ` Roberto Sassu
2022-07-19 11:50 ` Rob Landley
2022-07-19 12:26 ` Roberto Sassu
2022-07-19 14:14 ` Rob Landley
2022-07-20 11:52 ` Roberto Sassu
2022-07-29 10:37 ` Jim Baxter
2022-07-30 9:39 ` Rob Landley
2022-07-19 11:33 ` Rob Landley
2022-07-19 11:00 ` Rob Landley
2019-07-01 13:22 ` Mimi Zohar
2022-06-15 15:50 ` Alexander Lobakin
2022-06-15 16:03 ` Roberto Sassu
2022-06-16 13:24 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615175412.GA7029@lxhi-065 \
--to=erosca@de.adit-jv.com \
--cc=arnd@arndb.de \
--cc=bug-cpio@gnu.org \
--cc=dirk.behme@de.bosch.com \
--cc=dmitry.kasatkin@huawei.com \
--cc=hpa@zytor.com \
--cc=initramfs@vger.kernel.org \
--cc=james.w.mcmechan@gmail.com \
--cc=kamensky@cisco.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=niveditas98@gmail.com \
--cc=rob@landley.net \
--cc=roberto.sassu@huawei.com \
--cc=roscaeugeniu@gmail.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=takondra@cisco.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).