From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org
Subject: Re: [PATCH ima-evm-utils] fsverity.test: Add /usr/sbin into $PATH
Date: Mon, 13 Mar 2023 08:22:22 +0100 [thread overview]
Message-ID: <20230313072222.GA550975@pevik> (raw)
In-Reply-To: <fee39e794cec39474b54d5a3da3a79e40acdce47.camel@linux.ibm.com>
Hi Mimi,
> On Fri, 2023-03-10 at 11:47 +0100, Petr Vorel wrote:
> > Unlike GitHub CI, tests which run by packaging tools often run as non-root,
> > thus required tools aren't visible:
> > ./functions.sh: line 45: type: mkfs: not found
> > mkfs is required for test
> > ./functions.sh: line 45: type: blkid: not found
> > blkid is required for test
> > ./functions.sh: line 45: type: e2fsck: not found
> > e2fsck is required for test
> > ./functions.sh: line 45: type: tune2fs: not found
> > tune2fs is required for test
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Hi Mimi,
> > some would maybe appreciate option to skip all tests,
> > but this is enough for me.
> Hi Petr,
> Thank you for the patch. It's now queued in next-testing.
Thank you.
> The UML kernel opens up a lot of options going forward. For now all
> the tests are lumped together, but they should be separated based on
> ima-evm-utils selftests vs. the kernel tests. Even that might not be
> granular enough.
Thanks for info, sounds reasonable.
> For now from the command line, the environment variable "TESTS"
> overrides the set of tests as defined in the Makefile to execute. For
> example, "export TESTS="ima_sign.test sign_verify.test"; make -e check"
> executes just the two tests.
Also, TESTS= would skip all the tests (but prefer to run them).
> Also commit b573b7d4a186 ("Introduce TST_LIST variable to select a test
> to execute") can define the set of tests to execute.
Good to know (this one is hidden in test functions).
Kind regards,
Petr
prev parent reply other threads:[~2023-03-13 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 10:47 [PATCH ima-evm-utils] fsverity.test: Add /usr/sbin into $PATH Petr Vorel
2023-03-10 19:38 ` Mimi Zohar
2023-03-13 7:22 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313072222.GA550975@pevik \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).