Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] tpm: Fix the description error of the help information in Kconfig
@ 2020-07-27  2:53 Tianjia Zhang
  2020-07-27  7:10 ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Tianjia Zhang @ 2020-07-27  2:53 UTC (permalink / raw)
  To: peterhuewe, jarkko.sakkinen, jgg, arnd, gregkh, linux-integrity,
	linux-kernel
  Cc: tianjia.zhang

Obviously, the TPM version number in the help message is wrong, which
will cause confusion. This patch fixes it.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
 drivers/char/tpm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 58b4c573d176..8eedb3e704f3 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -62,7 +62,7 @@ config TCG_TIS_SPI
 	help
 	  If you have a TPM security chip which is connected to a regular,
 	  non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
-	  TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
+	  TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
 	  specification (TPM2.0) say Yes and it will be accessible from
 	  within Linux. To compile this driver as a module, choose  M here;
 	  the module will be called tpm_tis_spi.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm: Fix the description error of the help information in Kconfig
  2020-07-27  2:53 [PATCH] tpm: Fix the description error of the help information in Kconfig Tianjia Zhang
@ 2020-07-27  7:10 ` Arnd Bergmann
  2020-07-27  8:25   ` Tianjia Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2020-07-27  7:10 UTC (permalink / raw)
  To: Tianjia Zhang
  Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, gregkh,
	linux-integrity, linux-kernel, Christophe Ricard, Peter Huewe,
	Alexander Steffen

On Mon, Jul 27, 2020 at 4:54 AM Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> Obviously, the TPM version number in the help message is wrong, which
> will cause confusion. This patch fixes it.

How is this "obvious"? I tried finding the specification and could not
see anything
to back up TIS 1.3 being only supported with TPM 1.3, or the existence of a
TPM 1.3 specification at all.

Please consider that not everyone reading this patch description is deeply
familiar with the details and explain exactly what the mistake is.

> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

In a bug fix, try to always add a 'FIxes' tag such as 'Fixes: 0edbfea537d1
("tpm/tpm_tis_spi: Add support for spi phy")', and Cc everyone that was
involved in the original patch that introduced a bug so they can Ack or
Nak it.

      Arnd

>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 58b4c573d176..8eedb3e704f3 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
>         help
>           If you have a TPM security chip which is connected to a regular,
>           non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
> -         TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
> +         TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
>           specification (TPM2.0) say Yes and it will be accessible from
>           within Linux. To compile this driver as a module, choose  M here;
>           the module will be called tpm_tis_spi.
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm: Fix the description error of the help information in Kconfig
  2020-07-27  7:10 ` Arnd Bergmann
@ 2020-07-27  8:25   ` Tianjia Zhang
  2020-07-27  8:33     ` Peter.Huewe
  0 siblings, 1 reply; 5+ messages in thread
From: Tianjia Zhang @ 2020-07-27  8:25 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, gregkh,
	linux-integrity, linux-kernel, Christophe Ricard, Peter Huewe,
	Alexander Steffen

Thanks for your advice, I have submitted a v2 patch.

Thanks,
Tianjia

On 2020/7/27 15:10, Arnd Bergmann wrote:
> On Mon, Jul 27, 2020 at 4:54 AM Tianjia Zhang
> <tianjia.zhang@linux.alibaba.com> wrote:
>>
>> Obviously, the TPM version number in the help message is wrong, which
>> will cause confusion. This patch fixes it.
> 
> How is this "obvious"? I tried finding the specification and could not
> see anything
> to back up TIS 1.3 being only supported with TPM 1.3, or the existence of a
> TPM 1.3 specification at all.
> 
> Please consider that not everyone reading this patch description is deeply
> familiar with the details and explain exactly what the mistake is.
> 
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> 
> In a bug fix, try to always add a 'FIxes' tag such as 'Fixes: 0edbfea537d1
> ("tpm/tpm_tis_spi: Add support for spi phy")', and Cc everyone that was
> involved in the original patch that introduced a bug so they can Ack or
> Nak it.
> 
>        Arnd
> 
>>   drivers/char/tpm/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
>> index 58b4c573d176..8eedb3e704f3 100644
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
>>          help
>>            If you have a TPM security chip which is connected to a regular,
>>            non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
>> -         TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
>> +         TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
>>            specification (TPM2.0) say Yes and it will be accessible from
>>            within Linux. To compile this driver as a module, choose  M here;
>>            the module will be called tpm_tis_spi.
>> --
>> 2.17.1
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] tpm: Fix the description error of the help information in Kconfig
  2020-07-27  8:25   ` Tianjia Zhang
@ 2020-07-27  8:33     ` Peter.Huewe
  2020-07-28 12:32       ` Tianjia Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Peter.Huewe @ 2020-07-27  8:33 UTC (permalink / raw)
  To: tianjia.zhang, arnd
  Cc: peterhuewe, jarkko.sakkinen, jgg, gregkh, linux-integrity,
	linux-kernel, christophe.ricard, Alexander.Steffen

Hi,
On 2020/7/27 15:10, Arnd Bergmann wrote:
> On Mon, Jul 27, 2020 at 4:54 AM Tianjia Zhang 
> <tianjia.zhang@linux.alibaba.com> wrote:
>>
>> Obviously, the TPM version number in the help message is wrong, which 
>> will cause confusion. This patch fixes it.
> 
> How is this "obvious"? I tried finding the specification and could not 
> see anything to back up TIS 1.3 being only supported with TPM 1.3, or 
> the existence of a TPM 1.3 specification at all.
> 
There is no TPM 1.3.

There is a TIS Specification 1.3 which applies to TPM1.2 
These are different specs, with different version numbers.
So the fix is incorrect.

Thanks,
Peter

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm: Fix the description error of the help information in Kconfig
  2020-07-27  8:33     ` Peter.Huewe
@ 2020-07-28 12:32       ` Tianjia Zhang
  0 siblings, 0 replies; 5+ messages in thread
From: Tianjia Zhang @ 2020-07-28 12:32 UTC (permalink / raw)
  To: Peter.Huewe, arnd
  Cc: peterhuewe, jarkko.sakkinen, jgg, gregkh, linux-integrity,
	linux-kernel, christophe.ricard, Alexander.Steffen


On 2020/7/27 16:33, Peter.Huewe@infineon.com wrote:
> Hi,
> On 2020/7/27 15:10, Arnd Bergmann wrote:
>> On Mon, Jul 27, 2020 at 4:54 AM Tianjia Zhang
>> <tianjia.zhang@linux.alibaba.com> wrote:
>>>
>>> Obviously, the TPM version number in the help message is wrong, which
>>> will cause confusion. This patch fixes it.
>>
>> How is this "obvious"? I tried finding the specification and could not
>> see anything to back up TIS 1.3 being only supported with TPM 1.3, or
>> the existence of a TPM 1.3 specification at all.
>>
> There is no TPM 1.3.
> 
> There is a TIS Specification 1.3 which applies to TPM1.2
> These are different specs, with different version numbers.
> So the fix is incorrect.
> 
> Thanks,
> Peter
> 

You are right, I was careless, thanks for your reply.

Thanks and best,
Tianjia

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27  2:53 [PATCH] tpm: Fix the description error of the help information in Kconfig Tianjia Zhang
2020-07-27  7:10 ` Arnd Bergmann
2020-07-27  8:25   ` Tianjia Zhang
2020-07-27  8:33     ` Peter.Huewe
2020-07-28 12:32       ` Tianjia Zhang

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git