From: Roberto Sassu <roberto.sassu@huawei.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: "zohar@linux.ibm.com" <zohar@linux.ibm.com>, "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [RFC][PATCH 04/12] digest_lists: Objects Date: Mon, 28 Jun 2021 08:14:41 +0000 [thread overview] Message-ID: <22fff08f1a70460da814d3f21b497f8b@huawei.com> (raw) In-Reply-To: <YNhZTR5VSin7ABZP@kroah.com> > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Sunday, June 27, 2021 12:56 PM > On Fri, Jun 25, 2021 at 06:56:06PM +0200, Roberto Sassu wrote: > > +++ b/security/integrity/digest_lists/digest_lists.h > > @@ -0,0 +1,117 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (C) 2005,2006,2007,2008 IBM Corporation > > + * Copyright (C) 2017-2021 Huawei Technologies Duesseldorf GmbH > > + * > > + * Author: Roberto Sassu <roberto.sassu@huawei.com> > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation, version 2 of the > > + * License. > > + * > > + * File: digest_lists.h > > + * Unexported definitions for digest lists. > > Unexported to whom? Hi Greg I meant not placed in include/linux. > > + */ > > + > > +#ifndef __DIGEST_LISTS_INTERNAL_H > > +#define __DIGEST_LISTS_INTERNAL_H > > + > > +#include <linux/types.h> > > +#include <linux/crypto.h> > > +#include <linux/fs.h> > > +#include <linux/security.h> > > +#include <linux/hash.h> > > +#include <linux/tpm.h> > > +#include <linux/audit.h> > > +#include <crypto/hash_info.h> > > +#include <linux/hash_info.h> > > +#include <uapi/linux/digest_lists.h> > > + > > +#define MAX_DIGEST_SIZE 64 > > +#define HASH_BITS 10 > > +#define MEASURE_HTABLE_SIZE (1 << HASH_BITS) > > + > > +struct digest_list_item { > > + loff_t size; > > + u8 *buf; > > + u8 actions; > > + u8 digest[64]; > > + enum hash_algo algo; > > + const char *label; > > +}; > > + > > +struct digest_list_item_ref { > > + struct digest_list_item *digest_list; > > + loff_t digest_offset; > > + loff_t hdr_offset; > > +}; > > + > > +struct digest_item { > > + /* hash table pointers */ > > + struct hlist_node hnext; > > + /* digest list references (protected by RCU) */ > > + struct digest_list_item_ref *refs; > > +}; > > + > > +struct h_table { > > + atomic_long_t len; > > Why is this atomic? Why would that matter? Yes, it shouldn't be. There are not concurrent updates. > > + struct hlist_head queue[MEASURE_HTABLE_SIZE]; > > +}; > > + > > +static inline unsigned int hash_key(u8 *digest) > > +{ > > + return (digest[0] | digest[1] << 8) % MEASURE_HTABLE_SIZE; > > +} > > Don't we have hashing functions in the kernel already? We had a discussion before: https://lore.kernel.org/linux-integrity/1587739544.5190.14.camel@linux.ibm.com/ It seems there is no real advantage in hashing a digest. > > + > > +static inline struct compact_list_hdr *get_hdr( > > + struct digest_list_item *digest_list, > > + loff_t hdr_offset) > > +{ > > + return (struct compact_list_hdr *)(digest_list->buf + hdr_offset); > > +} > > pointer math feels rough, are you shure you want to do this this way? Maybe, I could change digest_list_item_ref to: struct digest_list_item_ref { struct digest_list_item *digest_list; u8 *digest; struct compact_list_hdr *hdr; }; where digest and hdr are calculated in the same way. Or you have a different suggestion? Thanks Roberto HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli > thanks, > > greg k-h
next prev parent reply other threads:[~2021-06-28 8:14 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 16:56 [RFC][PATCH 00/12] Huawei Digest Lists Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 01/12] ima: Add digest, algo, measured parameters to ima_measure_critical_data() Roberto Sassu 2021-06-25 18:26 ` Mimi Zohar 2021-06-25 16:56 ` [RFC][PATCH 02/12] digest_lists: Overview Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 03/12] digest_lists: Basic definitions Roberto Sassu 2021-06-27 10:53 ` Greg KH 2021-06-27 15:23 ` Matthew Wilcox 2021-06-27 15:35 ` Greg KH 2021-06-28 8:30 ` Roberto Sassu 2021-06-28 8:46 ` Greg KH 2021-06-28 9:27 ` Roberto Sassu 2021-06-28 9:32 ` Greg KH 2021-06-28 9:51 ` Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 04/12] digest_lists: Objects Roberto Sassu 2021-06-27 10:56 ` Greg KH 2021-06-28 8:14 ` Roberto Sassu [this message] 2021-06-28 8:47 ` Greg KH 2021-06-25 16:56 ` [RFC][PATCH 05/12] digest_lists: Methods Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 06/12] digest_lists: Parser Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 07/12] digest_lists: Interfaces - digest_list_add, digest_list_del Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 08/12] digest_lists: Interfaces - digest_lists_loaded Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 09/12] digest_lists: Interfaces - digest_label Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 10/12] digest_lists: Interfaces - digest_query Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 11/12] digest_lists: Interfaces - digests_count Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 12/12] digest_lists: Tests Roberto Sassu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=22fff08f1a70460da814d3f21b497f8b@huawei.com \ --to=roberto.sassu@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=zohar@linux.ibm.com \ --subject='RE: [RFC][PATCH 04/12] digest_lists: Objects' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).