From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8309CC433E6 for ; Fri, 29 Jan 2021 18:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C62164E0B for ; Fri, 29 Jan 2021 18:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbhA2S7Y (ORCPT ); Fri, 29 Jan 2021 13:59:24 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35758 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232651AbhA2S7V (ORCPT ); Fri, 29 Jan 2021 13:59:21 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10TIXgna055616; Fri, 29 Jan 2021 13:58:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=gvlIQii1iYf+bscSq0IPvtHg7qQbBhSTXpfND6+KQac=; b=D652sdA17foaemZbO4smpJdhq3g7iOiKltQ2Dh1HcXoHREGCJle4sT08J4h5qXq6ky/q R+g2WTjhtxeQqNfYG9BIrvoeSI83Qa2+dI3XVPwxXPpfn3gSKA5ge5JL3dolpI7SwWnC 3kG9IlrTCKjVRJU6MDU3udiBauAvI7/06N+zhyRAA46ka/2j5+kZbH+4UPyxfRKV/JUD NVd0dAO0H7G7bXrFpZObIEyk0aWyDa2Rux1NAuPDyrUFaSk2s4MuL9RLQ+fJ5EsFKr41 XNuD4LDmiWgbMV0m/mYB9bT2UHM2qaAnk2W0ZAzSlsNuDjmaHHwIrlmPdoOps62rCOze yQ== Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 36cm08g336-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jan 2021 13:58:00 -0500 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10TIXIxY014876; Fri, 29 Jan 2021 18:57:59 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02wdc.us.ibm.com with ESMTP id 36acj9u9mw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jan 2021 18:57:59 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10TIvxUG36766000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Jan 2021 18:57:59 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E95E1AC05F; Fri, 29 Jan 2021 18:57:58 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC4CDAC059; Fri, 29 Jan 2021 18:57:58 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 29 Jan 2021 18:57:58 +0000 (GMT) Subject: Re: [PATCH v2] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe() To: Jarkko Sakkinen , Stefan Berger Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, linux-kernel@vger.kernel.org, Hulk Robot , Wang Hai References: <20210126014753.340299-1-stefanb@linux.vnet.ibm.com> From: Stefan Berger Message-ID: <262c3095-d4c0-f124-c8bc-e99685cbe572@linux.ibm.com> Date: Fri, 29 Jan 2021 13:57:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-01-29_06:2021-01-29,2021-01-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1011 mlxscore=0 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101290089 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 1/29/21 12:35 PM, Jarkko Sakkinen wrote: > On Mon, Jan 25, 2021 at 08:47:53PM -0500, Stefan Berger wrote: >> From: Stefan Berger >> >> Return error code -ETIMEDOUT rather than '0' when waiting for the >> rtce_buf to be set has timed out. >> >> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding") >> Reported-by: Hulk Robot >> Signed-off-by: Wang Hai >> Signed-off-by: Stefan Berger >> --- > Reviewed-by: Jarkko Sakkinen > > Thanks! Should I add > > Cc: stable@vger.kernel.org to this? Yes, that would be good! Thank you!    Stefan > > /Jarkko > > >> drivers/char/tpm/tpm_ibmvtpm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c >> index 994385bf37c0..813eb2cac0ce 100644 >> --- a/drivers/char/tpm/tpm_ibmvtpm.c >> +++ b/drivers/char/tpm/tpm_ibmvtpm.c >> @@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, >> ibmvtpm->rtce_buf != NULL, >> HZ)) { >> dev_err(dev, "CRQ response timed out\n"); >> + rc = -ETIMEDOUT; >> goto init_irq_cleanup; >> } >> >> -- >> 2.25.4 >> >>