Linux-Integrity Archive on lore.kernel.org
 help / Atom feed
From: Alexander Steffen <Alexander.Steffen@infineon.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Stefan Berger <stefanb@linux.ibm.com>
Cc: <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-security-module@vger.kernel.org>,
	Peter Huewe <PeterHuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour
Date: Mon, 11 Feb 2019 16:05:39 +0100
Message-ID: <2849751f-ff26-193e-f15e-4d7d5f8525a7@infineon.com> (raw)
In-Reply-To: <20190208190057.GA3439@linux.intel.com>

On 08.02.2019 20:00, Jarkko Sakkinen wrote:
> On Fri, Feb 08, 2019 at 01:12:34PM -0500, Stefan Berger wrote:
>> On 2/8/19 1:08 PM, Jarkko Sakkinen wrote:
>>> The send() callback should never return length as it does not in every
>>> driver except tpm_crb in the success case. The reason is that the main
>>> transmit functionality only cares about whether the transmit was
>>> successful or not and ignores the count completely.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>
>> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Let me know when you put it into your tree, I'll give it a spin while I am
>> at it. :-)
> 
> Thank you Stefan! I also add your suggested-by to the first commit
> because you pointed out the problem.
> 
> It all looks now legit, but just in case I'll add a check for the return
> value to tpm_try_transmit() and a warning if it is not zero in the
> success case (and after that zeroing of rc).
> 
> That check can be removed when I do v5.3 pull request. That should
> enough window to catch any potential issues and check will ensure that
> kernel won't fail even there was something forgotten.
> 
> Alexander, I'll push this version now to the master and next with the
> additional check described in this commit, but will add your tags
> after you have time to test.

I ran all tests again and everything works now as expected :)

Tested-by: Alexander Steffen <Alexander.Steffen@infineon.com>

Alexander

  parent reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 18:08 [PATCH v4 0/2] tpm: Unify send() callbacks Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-08 18:12   ` Stefan Berger
2019-02-08 19:00     ` Jarkko Sakkinen
2019-02-08 19:17       ` [PATCH v4 1/2] tpm: Unify the send callback behaviourä Jarkko Sakkinen
2019-02-08 19:27         ` Stefan Berger
2019-02-08 20:23           ` Jarkko Sakkinen
2019-02-08 20:32             ` Stefan Berger
2019-02-08 20:46               ` Jarkko Sakkinen
2019-02-08 21:18                 ` Stefan Berger
2019-02-08 21:51                   ` Jarkko Sakkinen
2019-02-08 20:38             ` Jarkko Sakkinen
2019-02-11 15:05       ` Alexander Steffen [this message]
2019-02-13  7:44         ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-09 18:20   ` Jerry Snitselaar
2019-02-09 20:01     ` Jerry Snitselaar
2019-02-11 13:58     ` Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Jarkko Sakkinen
2019-02-09 20:08 ` [PATCH v4 0/2] tpm: Unify send() callbacks Jerry Snitselaar
2019-02-11 14:03   ` Jarkko Sakkinen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2849751f-ff26-193e-f15e-4d7d5f8525a7@infineon.com \
    --to=alexander.steffen@infineon.com \
    --cc=PeterHuewe@gmx.de \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org linux-integrity@archiver.kernel.org
	public-inbox-index linux-integrity


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/ public-inbox