* [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
@ 2020-03-19 1:00 Stefan Berger
2020-03-19 19:57 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Berger @ 2020-03-19 1:00 UTC (permalink / raw)
To: jarkko.sakkinen, linux-integrity
Cc: linux-kernel, linux-next, linuxppc-dev, sachinp, mpe, Stefan Berger
From: Stefan Berger <stefanb@linux.ibm.com>
This patch fixes the following problem when the ibmvtpm driver
is built as a module:
ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2
Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm2-cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 76f67b155bd5..eff1f12d981a 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -681,6 +681,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
rc = -ENODEV;
return rc;
}
+EXPORT_SYMBOL_GPL(tpm2_get_cc_attrs_tbl);
/**
* tpm2_startup - turn on the TPM
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
2020-03-19 1:00 [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger
@ 2020-03-19 19:57 ` Jarkko Sakkinen
2020-04-01 9:10 ` Sachin Sant
0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-03-19 19:57 UTC (permalink / raw)
To: Stefan Berger
Cc: linux-integrity, linux-kernel, linux-next, linuxppc-dev, sachinp,
mpe, Stefan Berger
On Wed, Mar 18, 2020 at 09:00:17PM -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
>
> This patch fixes the following problem when the ibmvtpm driver
> is built as a module:
>
> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1298: modules] Error 2
>
> Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Should have "tpm:" tag in the short summary.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
2020-03-19 19:57 ` Jarkko Sakkinen
@ 2020-04-01 9:10 ` Sachin Sant
2020-04-02 19:31 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Sachin Sant @ 2020-04-01 9:10 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Stefan Berger, linux-integrity, LKML, linux-next, linuxppc-dev,
mpe, Stefan Berger
> On 20-Mar-2020, at 1:27 AM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
>
> On Wed, Mar 18, 2020 at 09:00:17PM -0400, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> This patch fixes the following problem when the ibmvtpm driver
>> is built as a module:
>>
>> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
>> make: *** [Makefile:1298: modules] Error 2
>>
>> Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>
Ping. This failure can now be seen in mainline (cad18da0af) as well.
Thanks
-Sachin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
2020-04-01 9:10 ` Sachin Sant
@ 2020-04-02 19:31 ` Jarkko Sakkinen
2020-04-14 0:51 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-04-02 19:31 UTC (permalink / raw)
To: Sachin Sant
Cc: Stefan Berger, linux-integrity, LKML, linux-next, linuxppc-dev,
mpe, Stefan Berger
On Wed, Apr 01, 2020 at 02:40:30PM +0530, Sachin Sant wrote:
>
>
> > On 20-Mar-2020, at 1:27 AM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Wed, Mar 18, 2020 at 09:00:17PM -0400, Stefan Berger wrote:
> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >>
> >> This patch fixes the following problem when the ibmvtpm driver
> >> is built as a module:
> >>
> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
> >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> >> make: *** [Makefile:1298: modules] Error 2
> >>
> >> Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> >> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> >
>
> Ping. This failure can now be seen in mainline (cad18da0af) as well.
It is in my tree
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
2020-04-02 19:31 ` Jarkko Sakkinen
@ 2020-04-14 0:51 ` Michael Ellerman
2020-04-14 7:29 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2020-04-14 0:51 UTC (permalink / raw)
To: Jarkko Sakkinen, Sachin Sant
Cc: Stefan Berger, linux-integrity, LKML, linux-next, linuxppc-dev,
Stefan Berger
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> writes:
> On Wed, Apr 01, 2020 at 02:40:30PM +0530, Sachin Sant wrote:
>> > On 20-Mar-2020, at 1:27 AM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
>> >
>> > On Wed, Mar 18, 2020 at 09:00:17PM -0400, Stefan Berger wrote:
>> >> From: Stefan Berger <stefanb@linux.ibm.com>
>> >>
>> >> This patch fixes the following problem when the ibmvtpm driver
>> >> is built as a module:
>> >>
>> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>> >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
>> >> make: *** [Makefile:1298: modules] Error 2
>> >>
>> >> Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
>> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>> >> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>> >> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>> >
>>
>> Ping. This failure can now be seen in mainline (cad18da0af) as well.
>
> It is in my tree
Can you please send it to Linus?
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
2020-04-14 0:51 ` Michael Ellerman
@ 2020-04-14 7:29 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-04-14 7:29 UTC (permalink / raw)
To: Michael Ellerman
Cc: Sachin Sant, Stefan Berger, linux-integrity, LKML, linux-next,
linuxppc-dev, Stefan Berger
On Tue, Apr 14, 2020 at 10:51:37AM +1000, Michael Ellerman wrote:
> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> writes:
> > On Wed, Apr 01, 2020 at 02:40:30PM +0530, Sachin Sant wrote:
> >> > On 20-Mar-2020, at 1:27 AM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> >> >
> >> > On Wed, Mar 18, 2020 at 09:00:17PM -0400, Stefan Berger wrote:
> >> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >> >>
> >> >> This patch fixes the following problem when the ibmvtpm driver
> >> >> is built as a module:
> >> >>
> >> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
> >> >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> >> >> make: *** [Makefile:1298: modules] Error 2
> >> >>
> >> >> Fixes: 18b3670d79ae ("tpm: ibmvtpm: Add support for TPM2")
> >> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> >> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> >> >> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> >> >
> >>
> >> Ping. This failure can now be seen in mainline (cad18da0af) as well.
> >
> > It is in my tree
>
> Can you please send it to Linus?
>
> cheers
Yes.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-14 7:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 1:00 [PATCH v2] qtpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger
2020-03-19 19:57 ` Jarkko Sakkinen
2020-04-01 9:10 ` Sachin Sant
2020-04-02 19:31 ` Jarkko Sakkinen
2020-04-14 0:51 ` Michael Ellerman
2020-04-14 7:29 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).