From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: Casey Schaufler <casey@schaufler-ca.com>,
Jann Horn <jannh@google.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Biggers <ebiggers@kernel.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1] ima: verify mprotect change is consistent with mmap policy
Date: Tue, 5 May 2020 10:52:12 -0700 [thread overview]
Message-ID: <2ae3adf2-25cb-eb6f-4615-85e3ac493161@linux.microsoft.com> (raw)
In-Reply-To: <1588699845-6196-1-git-send-email-zohar@linux.ibm.com>
On 5/5/20 10:30 AM, Mimi Zohar wrote:
> Files can be mmap'ed read/write and later changed to execute to circumvent
> IMA's mmap appraise policy rules. Due to locking issues (mmap semaphore
> would be taken prior to i_mutex), files can not be measured or appraised at
> this point. Eliminate this integrity gap, by denying the mprotect
> PROT_EXECUTE change, if an mmap appraise policy rule exists.
>
> On mprotect change success, return 0. On failure, return -EACESS.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> Changelog v1:
> - Reverse tests to remove code indentation. (Lakshmi Ramasubramanian)
> - General code cleanup, including adding comments.
>
> include/linux/ima.h | 7 ++++++
> security/integrity/ima/ima_main.c | 51 +++++++++++++++++++++++++++++++++++++++
> security/security.c | 7 +++++-
> 3 files changed, 64 insertions(+), 1 deletion(-)
Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
prev parent reply other threads:[~2020-05-05 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 17:30 [RFC PATCH v1] ima: verify mprotect change is consistent with mmap policy Mimi Zohar
2020-05-05 17:52 ` Lakshmi Ramasubramanian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ae3adf2-25cb-eb6f-4615-85e3ac493161@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=casey@schaufler-ca.com \
--cc=ebiggers@kernel.org \
--cc=jannh@google.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).