From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>,
Oshri Alkoby <oshrialkoby85@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de,
jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org,
oshri.alkoby@nuvoton.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, gcwilson@us.ibm.com,
kgoldman@us.ibm.com, nayna@linux.vnet.ibm.com,
dan.morav@nuvoton.com, tomer.maimon@nuvoton.com
Subject: Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp
Date: Fri, 05 Jul 2019 14:15:37 +0300 [thread overview]
Message-ID: <2e2e646c3fae87307a149ee06e9fd4a7e493830d.camel@linux.intel.com> (raw)
In-Reply-To: <79e8bfd2-2ed1-cf48-499c-5122229beb2e@infineon.com>
On Thu, 2019-07-04 at 13:29 +0200, Alexander Steffen wrote:
> On 04.07.2019 10:43, Jarkko Sakkinen wrote:
> > Check out tpm_tis_core.c and tpm_tis_spi.c. TPM TIS driver implements
> > that spec so you should only implement a new physical layer.
>
> I had the same thought. Unfortunately, the I2C-TIS specification
> introduces two relevant changes compared to tpm_tis/tpm_tis_spi:
I doubt that there was any comparison made.
> 1. Locality is not encoded into register addresses anymore, but stored
> in a separate register.
> 2. Several register addresses have changed (but still contain compatible
> contents).
>
> I'd still prefer not to duplicate all the high-level logic from
> tpm_tis_core. But this will probably mean to introduce some new
> interfaces between tpm_tis_core and the physical layers.
Agreed. Some plumbing needs to be done in tpm_tis_core to make it work
for this. We definitely do not want to duplicate code that has been
field tested for years.
> Also, shouldn't the new driver be called tpm_tis_i2c, to group it with
> all the other (TIS) drivers, that implement a vendor-independent
> protocol? With tpm_i2c_ptp users might assume that ptp is just another
> vendor.
Yes, absolutely. I guess the driver has been done without looking at
what already exist in the TPM kernel stack.
/Jarkko
next prev parent reply other threads:[~2019-07-05 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 15:13 [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp Oshri Alkoby
2019-06-28 15:13 ` [PATCH v2 1/2] dt-bindings: tpm: add the TPM I2C PTP device tree binding documentation Oshri Alkoby
2019-06-28 15:13 ` [PATCH v2 2/2] char: tpm: add new driver for tpm i2c ptp Oshri Alkoby
2019-07-04 8:43 ` [PATCH v2 0/2] " Jarkko Sakkinen
2019-07-04 11:29 ` Alexander Steffen
2019-07-05 11:15 ` Jarkko Sakkinen [this message]
[not found] ` <CAM9mBwJC2QD5-gV1eJUDzC2Fnnugr-oCZCoaH2sT_7ktFDkS-Q@mail.gmail.com>
2019-07-05 11:28 ` Jarkko Sakkinen
[not found] ` <6e7ff1b958d84f6e8e585fd3273ef295@NTILML02.nuvoton.com>
[not found] ` <CAP6Zq1hPo9dG71YFyr7z9rjmi-DvoUZJOme4+2uqsfO+7nH+HQ@mail.gmail.com>
2019-07-15 9:45 ` Jarkko Sakkinen
2019-07-18 12:51 ` Eyal.Cohen
2019-07-18 17:10 ` Alexander Steffen
2019-07-30 8:39 ` Benoit HOUYERE
2019-07-30 17:42 ` Alexander Steffen
2019-09-06 12:16 ` Benoit HOUYERE
2019-08-15 17:03 ` Oshri Alkobi
2019-08-16 16:12 ` Alexander Steffen
2019-08-25 11:25 ` Oshri Alkobi
2019-07-17 7:48 ` Alexander Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e2e646c3fae87307a149ee06e9fd4a7e493830d.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=arnd@arndb.de \
--cc=dan.morav@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=tomer.maimon@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).