From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B196C433DF for ; Tue, 9 Jun 2020 18:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5577020734 for ; Tue, 9 Jun 2020 18:03:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="HZqrRLQR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387732AbgFISDc (ORCPT ); Tue, 9 Jun 2020 14:03:32 -0400 Received: from linux.microsoft.com ([13.77.154.182]:37326 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733193AbgFISDb (ORCPT ); Tue, 9 Jun 2020 14:03:31 -0400 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 1AE4320B717B; Tue, 9 Jun 2020 11:03:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1AE4320B717B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1591725809; bh=RcRx8d20bjJpLdKxUmDt/7K3aLBKNzYGLcu36Ac8y94=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HZqrRLQRrYDntNP1Jtw4oEaypC9lkwLUlI9j6+1PzvhOjT1Qc5LXxONmka95SLTCn 3XUFK/fUKZXRBC9WtrfrgBuaRLu7C85Q64Vzi4k01hbp+a9ZcOYepI2+zI368Z2U07 WLCodQHxPAE6p/ZbRNCcEjr8ia3didJ0LTwcNoQo= Subject: Re: [PATCH v3] IMA: Add audit log for failure conditions To: Steve Grubb , Richard Guy Briggs Cc: linux-integrity@vger.kernel.org, linux-audit@redhat.com, zohar@linux.ibm.com, linux-kernel@vger.kernel.org References: <20200608215343.4491-1-nramas@linux.microsoft.com> <518a51b7-6c8d-f55f-c73a-b15abae8e0af@linux.microsoft.com> <20200609171555.itbllvtgjdanbbk7@madcap2.tricolour.ca> <2006844.2enhIMKrvE@x2> From: Lakshmi Ramasubramanian Message-ID: <2e3bc793-0d29-5434-1da3-2bcc34ed9012@linux.microsoft.com> Date: Tue, 9 Jun 2020 11:03:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <2006844.2enhIMKrvE@x2> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 6/9/20 10:35 AM, Steve Grubb wrote: >> >> If it is added, it should be appended to the end of the record since it >> is an existing record format, then in the case of res=1, errno= should >> still be present (not swing in and out) and just contain zero. (Or >> another value if there is a non-fatal warning?) > > This is not a searchable field, so it can go anywhere. If it is searchable, > ausearch expects ordering of other searchable fields. > Thank you for the clarification Steve. I'll add "errno=" right after "cause=". Also, "errno" will always be present - will be set to 0 if status is "success" (res=1) and a non-zero value for failure (res=0) thanks, -lakshmi