From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIM_ADSP_ALL, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D337C43441 for ; Sun, 11 Nov 2018 20:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AFEE20871 for ; Sun, 11 Nov 2018 20:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AFEE20871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mniewoehner.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-integrity-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbeKLGYm convert rfc822-to-8bit (ORCPT ); Mon, 12 Nov 2018 01:24:42 -0500 Received: from sender-of-o53.zoho.com ([135.84.80.218]:21770 "EHLO sender-of-o53.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730204AbeKLGYm (ORCPT ); Mon, 12 Nov 2018 01:24:42 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1541968499; cv=none; d=zoho.com; s=zohoarc; b=cHgYhbls4P6HQb531rTevqPTfPgXmAS7DQNP5BUFzJ4U/3tzFbxq2Xr6OJqqHfQe11ssVhmlXL3S5QmxuT5yjATIHJNa+CtdUGnEyALEKLCK9JjFoJoEVT+WMcXQY7QTyPCYYobXHxYSDsNn29551q0GLBge6zzBU5l5vBsdJGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1541968499; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=6aLDq0IGvp3jYLMHDYCndMH1Bquv5hA8rwpKkaqqdjE=; b=AdceMQni3iGqC4fjtOmiTbd+JuN3LTH9RFgLr5uOBLaP2/TxIeznkyXWlpcXb0Acte7plCl1qVD1AoA+J0DNy7FHRXa15WV09Cc6RngyZ4TL55TW2OtOKCP6/bdpiZMdxAc4b0tb+ADKvPNcmWXWW+dgKVqhQjKKPkJ62VmoTm4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=mniewoehner.de; spf=pass smtp.mailfrom=linux@mniewoehner.de; dmarc=pass header.from= header.from= Received: from z3r0 (31.187.91.78 [31.187.91.78]) by mx.zohomail.com with SMTPS id 1541968497299726.6354990952059; Sun, 11 Nov 2018 12:34:57 -0800 (PST) Message-ID: <3243d0325b3ea5878d3f86b0ee4fec1498f21dc1.camel@mniewoehner.de> Subject: Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: James Bottomley , peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca, arnd@arndb.de, linux-integrity@vger.kernel.org, linux-kernel In-Reply-To: <1541968191.3190.12.camel@HansenPartnership.com> References: <776f384a81466642472beb4a34b10f26f1de88e9.camel@mniewoehner.de> <1541960689.3190.4.camel@HansenPartnership.com> <1541962653.3190.7.camel@HansenPartnership.com> <7d8cc5ad4bb7548d283f363de6f24c90d5d0a2b2.camel@mniewoehner.de> <1541968191.3190.12.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 11 Nov 2018 21:34:54 +0100 Mime-Version: 1.0 X-Mailer: Evolution 3.28.5 Content-Transfer-Encoding: 8BIT X-ZohoMailClient: External Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > [...] > > > Well, I still think the ACPI setup is incorrect. What's in > > > /sys/class/platform (should be directories of ACPI devices)? The > > > TPM is supposed to show up as MSFT0101. If it doesn't is there any > > > other device string in there that might be a TPM? > > > > Nope. I'm not sure if it should show up in ACPI... isn't TPM 2.0 I2C? > > Your ACPI parser identifies it here: > > > [ 0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO TC- > > S06 00001300 AMI 00000000) > > So it has to be a device in the platform directory. What is in this > directory? To find the TPM it probably has something TPM like in the > firmware_node description: > > /sys/devices/platform//firmware_node/description > > Mine says > > jejb@jarvis:~/git/linux/drivers> cat > /sys/devices/platform/MSFT0101\:00/firmware_node/description > TPM 2.0 Device > Ah, yep. There is indeed a MSFT0101: (initramfs) cat /sys/devices/platform/MSFT0101\:00/firmware_node/description TPM 2.0 Device (initramfs) cat /sys/devices/platform/MSFT0101\:00/firmware_node/hid MSFT0101 (in itramfs) cat /sys/devices/platform/MSFT0101\:00/firmware_node/path \_SB_.TPM_ (in itramfs) cat /sys/devices/platform/MSFT0101\:00/firmware_node/status 15 (initramf s) cat /sys/devices/platform/MSFT0101\:00/firmware_node/uid 1 > James