From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93323C11F65 for ; Wed, 30 Jun 2021 21:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 621D761474 for ; Wed, 30 Jun 2021 21:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbhF3VfZ (ORCPT ); Wed, 30 Jun 2021 17:35:25 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45914 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbhF3VfY (ORCPT ); Wed, 30 Jun 2021 17:35:24 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15UL4OhG190310; Wed, 30 Jun 2021 17:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=FmkxlWkUtTcbkyDWFWrQjbT5298mVdjCz+TR4P7J4Vg=; b=FPaneqq1rstf6x9mIt7OlJAhsQ5757hEFFCpxVYFYbTztGVRv/jG4pFi9xcetDjLgpxY zf1HqO/N2mfCNFcIYbdyuZkkA21aMccSOg2h+8TtWysz39Oi0Crs77I3gsSa2bIQa9hL BEG0lzbJe2fbBsmN4IxqqpScXzaOUngay9hku8CZl+Dtf/wJhxkQfnziCjAyrFbzId+n P2Idl5/gkkw5AhvrX3nwtFWZ8Qh+u7XmVYjU4bEtmZ2suVRFD3Z1c68J+nXeHsXM4l80 /jpzITZ0NZ0RkYeQq4wn9BB+SvbQ6pPo1sF6pmyWwCziSB+zyAzZ+J4oRYo9yATODHrz Dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39gvmkq0y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 17:32:53 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15UL5ZHU007456; Wed, 30 Jun 2021 17:32:52 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 39gvmkq0xr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 17:32:52 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15ULNoEc005589; Wed, 30 Jun 2021 21:32:51 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06fra.de.ibm.com with ESMTP id 39dugh91qs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 21:32:50 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15ULWm5F34013674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Jun 2021 21:32:48 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48EE952057; Wed, 30 Jun 2021 21:32:48 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.160.114.126]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id EB58352051; Wed, 30 Jun 2021 21:32:46 +0000 (GMT) Message-ID: <365c28aca3a219ad5b742988f50f9b0d2e5f5db9.camel@linux.ibm.com> Subject: Re: [PATCH v6 1/3] ima-evm-utils: Allow manual setting keyid for signing From: Mimi Zohar To: Vitaly Chikunov Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org, "Dmitry V. Levin" Date: Wed, 30 Jun 2021 17:32:46 -0400 In-Reply-To: <20210630211048.yx5vwneymszr5ssj@altlinux.org> References: <20210511115630.795208-1-vt@altlinux.org> <20210511115630.795208-2-vt@altlinux.org> <004b55594ab1d944e42dd7fd0d87df47b3c09114.camel@linux.ibm.com> <20210626004241.wkkjsbbesakszfkj@altlinux.org> <20210629013201.xelhje2hmiuqybrt@altlinux.org> <2f494e1d5c2c99a4b7c0912faa4c3be3de682afc.camel@linux.ibm.com> <20210630194451.laico5ziqy3fw4eh@altlinux.org> <3aa852febc49d159783597b0de56060cf5efb269.camel@linux.ibm.com> <20210630211048.yx5vwneymszr5ssj@altlinux.org> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-16.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zRo4jAqjKenmFIICViVpmFx_haE2nWdP X-Proofpoint-GUID: KQYbcYXWJEa1mzh770tW4XUDUnaZmgCi X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-06-30_11:2021-06-30,2021-06-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 clxscore=1015 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106300115 Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2021-07-01 at 00:10 +0300, Vitaly Chikunov wrote: > Mimi, > > On Wed, Jun 30, 2021 at 04:47:53PM -0400, Mimi Zohar wrote: > > On Wed, 2021-06-30 at 22:44 +0300, Vitaly Chikunov wrote: > > > On Wed, Jun 30, 2021 at 12:39:02PM -0400, Mimi Zohar wrote: > > > > On Tue, 2021-06-29 at 04:32 +0300, Vitaly Chikunov wrote: > > > > > On Mon, Jun 28, 2021 at 04:50:42PM -0400, Mimi Zohar wrote: > > > > > > > > > > > > Thank you for the detailed explanation. > > > > > > > > > > > > On Sat, 2021-06-26 at 03:42 +0300, Vitaly Chikunov wrote: > > > > > > > > > > > > > > Requiring the optarg value to be prefixed with "0x" would > > > > > > > > simplify the strlen test. > > > > > > > > (The subsequent patch wouldn't need a contrived prefix.) > > > > > > > > > > > > > > (I do not understand this remark at the moment.) > > > > > > > > > > > > > > Base 16 will let user pass keyid just as a string, copy-pasting from > > > > > > > somewhere else. > > > > > > > > > > > > strtoul() supports prefixing the ascii-hex string with "0x". To > > > > > > differentiate between a keyid and pathname, why not require the keyid > > > > > > be prefixed with "0x", as opposed to requiring the pathname to be > > > > > > prefixed with '@', like "--keyid @/path/to/cert.pem". > > > > > > > > > > I wanted to avoid (filename vs keyid) ambiguity of the argument to > > > > > `--keyid' - if user have file named "0x00112233" they would have hard > > > > > time passing it to `--keyid'. But, it's impossible to have keyid string > > > > > starting with "@". So, "@" perfectly distinguish type of `--keyid' > > > > > argument but "0x" isn't. > > > > > > > > > > Also, in some software (zip, rar) "@" is common prefix meaning value > > > > > should be taken from the specified file. But, yes, "@" is not common > > > > > in Unix environments. Do you want me to create separate option like > > > > > `--keyid-from-file'? > > > > > > > > It's highly unlikely that both the filename and pathname would be > > > > prefixed with "0x". Defining a new option might be a good idea. > > > > Possibly naming it --extract-cert-keyid, ---cert-keyid, or --keyid- > > > > from-cert. > > > > > > It's not unlikely, because people may want to keep cert files named or > > > symlinked by keyid. (For example, local cert database keep cert files > > > symlinked like `f30dd6ad.0'.) > > > > > > I will add an option, most understandable, perhaps, is `--keyid-from-cert'. > > > > > > Also, I will remove base 16 from --keyid argument. > > > > I must be missing something. "openssl x509", "keyctl show > > %keyring:", and "getfattr -m security.ima -e hex --dump" > > all display the skid in hex. Why would anyone provide the skid as > > something other than in hex? > > Ah, I thought you want '0x' prefix mandatory. Will not remove base 16 > then. Also, /proc/keys shows keyid without '0x' prefix. Why? One doesn't preclude the other. "keyid = strtoul(optarg, &eptr, 16);" recognizes an "0x" prefixed string as being ascii-hex. Mimi