From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3657BC47404 for ; Fri, 11 Oct 2019 07:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1356220679 for ; Fri, 11 Oct 2019 07:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfJKHua (ORCPT ); Fri, 11 Oct 2019 03:50:30 -0400 Received: from gloria.sntech.de ([185.11.138.130]:36338 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbfJKHua (ORCPT ); Fri, 11 Oct 2019 03:50:30 -0400 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIpgx-0000mF-Tj; Fri, 11 Oct 2019 09:50:27 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jarkko Sakkinen Cc: Stephen Boyd , Peter Huewe , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Andrey Pronin , Duncan Laurie , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Alexander Steffen Subject: Re: [PATCH v7 0/6] tpm: Add driver for cr50 Date: Fri, 11 Oct 2019 09:50:27 +0200 Message-ID: <4042311.vcUrecXYXX@diego> In-Reply-To: <20191006223831.GA10397@linux.intel.com> References: <20190920183240.181420-1-swboyd@chromium.org> <20191006223831.GA10397@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Am Montag, 7. Oktober 2019, 00:39:00 CEST schrieb Jarkko Sakkinen: > On Fri, Sep 20, 2019 at 11:32:34AM -0700, Stephen Boyd wrote: > > This patch series adds support for the H1 secure microcontroller > > running cr50 firmware found on various recent Chromebooks. This driver > > is necessary to boot into a ChromeOS userspace environment. It > > implements support for several functions, including TPM-like > > functionality over a SPI interface. > > > > The last time this was series sent looks to be [1]. I've looked over the > > patches and review comments and tried to address any feedback that > > Andrey didn't address (really minor things like newlines). I've reworked > > the patches from the last version to layer on top of the existing TPM > > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more > > palatable than combining the two drivers together into one file. > > > > Please review so we can get the approach to supporting this device > > sorted out. > > > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@chromium.org [...] > OK, so, I put these to my master in hopes to get testing exposure. > I think the changes are in great shape now. Thank you. on a rk3399-gru-bob it works nicely for me, so Tested-by: Heiko Stuebner Thanks Heiko