From: David Howells <dhowells@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: dhowells@redhat.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v2 2/2] KEYS: Avoid false positive ENOMEM error on key read
Date: Mon, 09 Mar 2020 16:32:20 +0000 [thread overview]
Message-ID: <416690.1583771540@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200308170410.14166-3-longman@redhat.com>
Waiman Long <longman@redhat.com> wrote:
> + tmpbuf = kmalloc(tbuflen, GFP_KERNEL);
This would probably be better off using kvmalloc() - otherwise big objects
have to be constructed from runs of contiguous pages. But since all we're
doing is buffering for userspace, we don't care about that.
If you agree, we can address it with an additional patch.
David
next prev parent reply other threads:[~2020-03-09 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 17:04 [PATCH v2 0/2] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-08 17:04 ` [PATCH v2 1/2] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-13 1:04 ` Jarkko Sakkinen
2020-03-13 13:29 ` Waiman Long
2020-03-13 15:28 ` Jarkko Sakkinen
2020-03-13 16:57 ` Waiman Long
2020-03-08 17:04 ` [PATCH v2 2/2] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-09 16:32 ` David Howells [this message]
2020-03-10 15:45 ` Waiman Long
2020-03-10 15:58 ` Waiman Long
2020-03-10 17:12 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416690.1583771540@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=crecklin@redhat.com \
--cc=ebiggers@google.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=longman@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).