From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Joe Perches <joe@perches.com>, Mimi Zohar <zohar@linux.ibm.com>,
Tushar Sugandhi <tusharsu@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IMA: Add log statements for failure conditions.
Date: Mon, 10 Feb 2020 08:40:39 -0800 [thread overview]
Message-ID: <41d61aa5-db98-6291-d91f-104f029c897f@linux.microsoft.com> (raw)
In-Reply-To: <da7bd0441ef3044cb40d705b8bb176bfdf391557.camel@perches.com>
On 2/9/20 6:46 PM, Joe Perches wrote:
>>
>> In addition, as Shuah Khan suggested for the security/integrity/
>> directory, "there is an opportunity here to add #define pr_fmt(fmt)
>> KBUILD_MODNAME ": " fmt to integrity.h and get rid of duplicate
>> defines."
Good point - we'll make that change.
With Joe Perches patch (waiting for it to be re-posted),
>> are all the pr_fmt definitions needed in each file in the
>> integrity/ima directory?
>
> btw Tushar and Lakshmi:
>
> I am not formally submitting a patch here.
>
> I was just making suggestions and please do
> with it as you think appropriate.
Joe - it's not clear to me what you are suggesting.
We'll move the #define for pr_fmt to integrity.h.
What's other changes are you proposing?
>>>
>>> out:
>>> + if (ret < 0)
>>> + pr_err("Process buffer measurement failed, result: %d\n",
>>> + ret);
>>
>> There's no reason to split the statement like this. The joined line
>> is less than 80 characters.
Agree.
thanks,
-lakshmi
next prev parent reply other threads:[~2020-02-10 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 19:53 [PATCH] IMA: Updated KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-07 19:53 ` [PATCH] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-09 12:57 ` Mimi Zohar
2020-02-10 2:46 ` Joe Perches
2020-02-10 16:40 ` Lakshmi Ramasubramanian [this message]
2020-02-10 16:50 ` Joe Perches
2020-02-10 21:42 ` Tushar Sugandhi
[not found] ` <0c9099b5-da29-3e71-0933-123dfe08442c@linux.microsoft.com>
2020-02-10 21:46 ` Mimi Zohar
2020-02-10 22:19 ` Tushar Sugandhi
2020-06-04 16:32 Lakshmi Ramasubramanian
2020-06-05 18:46 ` Mimi Zohar
2020-06-05 19:37 ` Paul Moore
2020-06-05 19:54 ` Lakshmi Ramasubramanian
2020-06-05 20:49 ` Paul Moore
2020-06-05 21:09 ` Lakshmi Ramasubramanian
2020-06-05 21:34 ` Mimi Zohar
2020-06-05 21:36 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41d61aa5-db98-6291-d91f-104f029c897f@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=joe@perches.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=tusharsu@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).