From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43567C433FE for ; Fri, 11 Dec 2020 20:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E990C2311A for ; Fri, 11 Dec 2020 20:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405819AbgLKSg6 (ORCPT ); Fri, 11 Dec 2020 13:36:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394493AbgLKSgl (ORCPT ); Fri, 11 Dec 2020 13:36:41 -0500 Received: from smtp-42ab.mail.infomaniak.ch (smtp-42ab.mail.infomaniak.ch [IPv6:2001:1600:3:17::42ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F8AC0613CF for ; Fri, 11 Dec 2020 10:35:56 -0800 (PST) Received: from smtp-2-0001.mail.infomaniak.ch (unknown [10.5.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Cszwr3JjdzlhGWC; Fri, 11 Dec 2020 19:35:08 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4Cszwq4QFBzlh8TC; Fri, 11 Dec 2020 19:35:07 +0100 (CET) Subject: Re: [PATCH v1 2/9] certs: Make blacklist_vet_description() more strict To: David Howells Cc: David Woodhouse , "David S . Miller" , Herbert Xu , James Morris , Jarkko Sakkinen , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Mimi Zohar , "Serge E . Hallyn" , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20201120180426.922572-3-mic@digikod.net> <20201120180426.922572-1-mic@digikod.net> <113978.1607090965@warthog.procyon.org.uk> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <4362ac88-7514-27d2-f937-1cd405bd2e1a@digikod.net> Date: Fri, 11 Dec 2020 19:35:06 +0100 User-Agent: MIME-Version: 1.0 In-Reply-To: <113978.1607090965@warthog.procyon.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 04/12/2020 15:09, David Howells wrote: > Mickaël Salaün wrote: > >> + if (*desc) >> + /* The hash is greater than MAX_HASH_LEN. */ >> + return -EINVAL; > > -ENOPKG might be better. It's not that the string is invalid, it's just that > it's unsupported at the moment. Indeed, I'll use that. > > David >