From: Jia Zhang <zhang.jia@linux.alibaba.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: zohar@linux.ibm.com, linux-integrity@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [PATCH v3 5/6] ima: Rename the folder name for policy files to datafiles
Date: Thu, 24 Jan 2019 13:11:46 +0800 [thread overview]
Message-ID: <49244744-3546-c477-f443-a70ced4a4ed4@linux.alibaba.com> (raw)
In-Reply-To: <20190123170409.GA11731@dell5510>
On 2019/1/24 上午1:04, Petr Vorel wrote:
> Hi Mimi, Jia,
>
>> If we choose to run ima_policy.sh locally without installation,
>> a failure message is reported as following:
>
>> ima_policy 1 TCONF: missing <path>/ltp/testcases/kernel/security/integrity/ima/datafiles/measure.policy
>
>> TST_DATAROOT would be extended to datafiles but the policy files
>> are actually placed under policy.
>
>> In order to make it easier, just rename the folder name to datafiles.
>
>> Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
>> ---
>
> I wasn't sure about this one as make install isn't that hard to do even during
> debugging and policy is more descriptive. But other tests use datafiles as well,
> therefore taken as well.
Actually, this patch resolves the issue if we just follow this step to
run IMA-only test:
$ git clone https://github.com/linux-test-project/ltp.git
$ cd ltp
$ export LTP_ROOT="$PWD"
$ make autotools
$ ./configure
$ cd testcases/lib
$ make
$ cd ../kernel/security/integrity/ima
$ make
$ sudo PATH=$LTP_ROOT/testcases/lib:tests:$PATH ./tests/ima_policy.sh
A full LTP installation doesn't have this issue.
Jia
>
> Whole patchset merged, thank you both for your work.
>
> Kind regards,
> Petr
>
next prev parent reply other threads:[~2019-01-24 5:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 2:57 [LTP][PATCH v3 0/6] LTP IMA fix bundle Jia Zhang
2019-01-16 2:57 ` [PATCH v3 1/6] ima/ima_boot_aggregate: Fix the definition of event log Jia Zhang
2019-01-20 18:13 ` Mimi Zohar
2019-01-20 18:37 ` Mimi Zohar
2019-01-16 2:57 ` [PATCH v3 2/6] ima/ima_boot_aggregate: Don't hard code the length of sha1 hash Jia Zhang
2019-01-16 2:57 ` [PATCH v3 3/6] ima/ima_boot_aggregate: Fix extending PCRs beyond PCR 0-7 Jia Zhang
2019-01-16 2:57 ` [PATCH v3 4/6] ima: Code cleanup Jia Zhang
2019-01-16 2:57 ` [PATCH v3 5/6] ima: Rename the folder name for policy files to datafiles Jia Zhang
2019-01-23 17:04 ` Petr Vorel
2019-01-24 5:11 ` Jia Zhang [this message]
2019-01-16 2:57 ` [PATCH v3 6/6] ima/ima_violations: Temporarily remove the printk rate limit Jia Zhang
2019-01-20 18:38 ` Mimi Zohar
2019-01-16 7:20 ` [LTP][PATCH v3 0/6] LTP IMA fix bundle Petr Vorel
2019-01-20 14:59 ` Jia Zhang
2019-01-24 2:19 ` Jia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49244744-3546-c477-f443-a70ced4a4ed4@linux.alibaba.com \
--to=zhang.jia@linux.alibaba.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).