From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] tpm: Fix null pointer dereference on chip register error path
Date: Mon, 08 Jul 2019 17:34:42 +0300 [thread overview]
Message-ID: <58070e5ee4e64b10df063b61612b021c23f0fc14.camel@linux.intel.com> (raw)
In-Reply-To: <20190704072615.31143-1-gmazyland@gmail.com>
On Thu, 2019-07-04 at 09:26 +0200, Milan Broz wrote:
> If clk_enable is not defined and chip initialization
> is canceled code hits null dereference.
>
> Easily reproducible with vTPM init fail:
> swtpm chardev --tpmstate dir=nonexistent_dir --tpm2 --vtpm-proxy
>
> BUG: kernel NULL pointer dereference, address: 00000000
> ...
> Call Trace:
> tpm_chip_start+0x9d/0xa0 [tpm]
> tpm_chip_register+0x10/0x1a0 [tpm]
> vtpm_proxy_work+0x11/0x30 [tpm_vtpm_proxy]
> process_one_work+0x214/0x5a0
> worker_thread+0x134/0x3e0
> ? process_one_work+0x5a0/0x5a0
> kthread+0xd4/0x100
> ? process_one_work+0x5a0/0x5a0
> ? kthread_park+0x90/0x90
> ret_from_fork+0x19/0x24
>
> Fixes: 719b7d81f204 ("tpm: introduce tpm_chip_start() and tpm_chip_stop()")
> Cc: stable@vger.kernel.org # v5.1+
> Signed-off-by: Milan Broz <gmazyland@gmail.com>
Looks legit.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2019-07-08 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 8:42 [PATCH] tpm: Fix null pointer dereference on chip register error path Milan Broz
2019-06-12 20:57 ` James Morris
2019-06-14 21:56 ` Sasha Levin
2019-06-15 6:28 ` Milan Broz
2019-06-28 7:56 ` Milan Broz
2019-07-02 18:37 ` Jarkko Sakkinen
2019-07-03 23:01 ` Jarkko Sakkinen
2019-07-04 7:26 ` [PATCH v2] " Milan Broz
2019-07-08 14:34 ` Jarkko Sakkinen [this message]
2019-07-08 14:44 ` Jarkko Sakkinen
2019-07-05 17:52 ` [PATCH] " Jarkko Sakkinen
2019-07-05 21:23 ` Milan Broz
2019-07-08 14:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58070e5ee4e64b10df063b61612b021c23f0fc14.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gmazyland@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).