From: Stephen Boyd <swboyd@chromium.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Andrey Pronin <apronin@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v5 4/4] tpm: tpm_tis_spi: Support cr50 devices
Date: Thu, 29 Aug 2019 09:48:50 -0700 [thread overview]
Message-ID: <5d6801f3.1c69fb81.58389.32c9@mx.google.com> (raw)
In-Reply-To: <20190829163221.72njmrixakywqi5z@linux.intel.com>
Quoting Jarkko Sakkinen (2019-08-29 09:32:21)
> On Wed, Aug 28, 2019 at 01:21:50AM -0700, Stephen Boyd wrote:
> > diff --git a/drivers/char/tpm/cr50_spi.c b/drivers/char/tpm/cr50_spi.c
> > new file mode 100644
> > index 000000000000..535674f4b02a
> > --- /dev/null
> > +++ b/drivers/char/tpm/cr50_spi.c
> > @@ -0,0 +1,327 @@
[...]
> > +
> > +#ifdef CONFIG_PM_SLEEP
> > +int tpm_tis_spi_resume(struct device *dev)
> > +{
> > + struct tpm_chip *chip = dev_get_drvdata(dev);
> > + struct tpm_tis_data *data = dev_get_drvdata(&chip->dev);
> > + struct tpm_tis_spi_phy *phy = to_tpm_tis_spi_phy(data);
> > + struct cr50_spi_phy *cr50_phy;
> > +
> > + if (phy->is_cr50) {
> > + cr50_phy = to_cr50_spi_phy(phy);
> > + /*
> > + * Jiffies not increased during suspend, so we need to reset
> > + * the time to wake Cr50 after resume.
> > + */
> > + cr50_phy->wake_after = jiffies;
> > + }
>
> To simplify the code I would just put also wake_after to
> tpm_tis_spi_phy.
Ok. But keep the other members in cr50_spi_phy as they are?
>
> > +
> > + return tpm_tis_resume(dev);
> > +}
> > +#endif
> > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
> > index b3ed85671dd8..fdac842a61ed 100644
> > --- a/drivers/char/tpm/tpm_tis_spi.c
> > +++ b/drivers/char/tpm/tpm_tis_spi.c
> > @@ -215,17 +219,18 @@ static int tpm_tis_spi_probe(struct spi_device *dev)
> > {
> > struct tpm_tis_spi_phy *phy;
> > int irq;
> > + struct device_node *np = dev->dev.of_node;
> > + const struct spi_device_id *spi_dev_id = spi_get_device_id(dev);
> > +
> > + if (of_device_is_compatible(np, "google,cr50") ||
> > + (spi_dev_id && spi_dev_id->driver_data == TPM_IS_CR50))
> > + return cr50_spi_probe(dev);
>
> You could keep pointers to probes directly in driver_data.
Ok. Will do.
next prev parent reply other threads:[~2019-08-29 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 8:21 [PATCH v5 0/4] tpm: Add driver for cr50 Stephen Boyd
2019-08-28 8:21 ` [PATCH v5 1/4] dt-bindings: tpm: document properties " Stephen Boyd
2019-08-29 16:14 ` Jarkko Sakkinen
2019-08-28 8:21 ` [PATCH v5 2/4] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-08-28 8:21 ` [PATCH v5 3/4] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-08-29 16:22 ` Jarkko Sakkinen
2019-08-28 8:21 ` [PATCH v5 4/4] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-08-28 17:36 ` Heiko Stuebner
2019-08-28 18:07 ` Stephen Boyd
2019-08-28 18:28 ` Heiko Stuebner
2019-08-29 16:32 ` Jarkko Sakkinen
2019-08-29 16:48 ` Stephen Boyd [this message]
2019-08-29 18:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6801f3.1c69fb81.58389.32c9@mx.google.com \
--to=swboyd@chromium.org \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).