From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jarkko.sakkinen@linux.intel.com" <jarkko.sakkinen@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jgg@ziepe.ca" <jgg@ziepe.ca>, "arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays
Date: Thu, 12 Dec 2019 07:21:20 +0000 [thread overview]
Message-ID: <6920bc5e8bc932dd85fa8e14755d2e6999512f25.camel@analog.com> (raw)
In-Reply-To: <20191211173700.GE4516@linux.intel.com>
On Wed, 2019-12-11 at 19:37 +0200, Jarkko Sakkinen wrote:
> [External]
>
> On Tue, Dec 10, 2019 at 08:56:19AM +0200, Alexandru Ardelean wrote:
> > In a recent change to the SPI subsystem [1], a new `delay` struct was
> > added
> > to replace the `delay_usecs`. This change replaces the current
> > `delay_usecs`
> > with `delay` for this driver.
> >
> > The `spi_transfer_delay_exec()` function [in the SPI framework] makes
> > sure
> > that both `delay_usecs` & `delay` are used (in this order to preserve
> > backwards compatibility).
> >
> > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > `spi_transfer` + spi_transfer_delay_exec()")
>
> Not sure why you use ` and not '?
That's a habit from Github's Markdown.
We keep our kernel repo on Github and Markdown formats `text` into a
certain form.
When I open a PR, the PR text is formatted to highlight certain elements
[that I want highlighted].
I did not get any comments on it so far.
I can change it if you want.
As a secondary note: Markdown seems to be used on Gitlab and Bitbucket
Thanks
Alex
>
> /Jarkko
next prev parent reply other threads:[~2019-12-12 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 8:00 [PATCH] tpm_tis_spi: use new `delay` structure for SPI transfer delays Alexandru Ardelean
2019-12-09 19:50 ` Jarkko Sakkinen
2019-12-10 6:56 ` [PATCH V2] " Alexandru Ardelean
2019-12-11 17:37 ` Jarkko Sakkinen
2019-12-12 7:21 ` Ardelean, Alexandru [this message]
2019-12-17 1:26 ` Jarkko Sakkinen
2019-12-17 9:16 ` [PATCH V3] tpm_tis_spi: use new 'delay' " Alexandru Ardelean
2019-12-17 12:04 ` Jarkko Sakkinen
2020-02-26 7:51 ` Ardelean, Alexandru
2020-02-26 15:10 ` Jarkko Sakkinen
2020-02-26 15:11 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6920bc5e8bc932dd85fa8e14755d2e6999512f25.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).