From: Markus Elfring <Markus.Elfring@web.de>
To: David Laight <David.Laight@ACULAB.COM>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <jmorris@namei.org>,
Mimi Zohar <zohar@linux.ibm.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: ima: Replace two seq_printf() calls by seq_puts() in ima_show_template_data_ascii()
Date: Wed, 3 Jul 2019 11:33:22 +0200 [thread overview]
Message-ID: <6b7db918-8d0b-b280-91e4-c15e22451cfc@web.de> (raw)
In-Reply-To: <d94bfdb9d53b46059787b9bdd10c5919@AcuMS.aculab.com>
> So this is probably just a minor performance improvement in a code
> path where it really doesn't matter.
I imagine that another small software adjustment can help a bit
to get nicer run time characteristics also at this place.
>> +++ b/security/integrity/ima/ima_template_lib.c
>> @@ -74,7 +74,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,
>> case DATA_FMT_DIGEST_WITH_ALGO:
>> buf_ptr = strnchr(field_data->data, buflen, ':');
>> if (buf_ptr != field_data->data)
>> - seq_printf(m, "%s", field_data->data);
>> + seq_puts(m, field_data->data);
>>
>> /* skip ':' and '\0' */
>> buf_ptr += 2;
>
> That code looks highly suspect!
Would you like to change this implementation detail any more?
Regards,
Markus
next prev parent reply other threads:[~2019-07-03 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 19:00 [PATCH] ima: Replace two seq_printf() calls by seq_puts() in ima_show_template_data_ascii() Markus Elfring
2019-07-03 9:16 ` David Laight
2019-07-03 9:33 ` Markus Elfring [this message]
2019-07-03 11:14 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7db918-8d0b-b280-91e4-c15e22451cfc@web.de \
--to=markus.elfring@web.de \
--cc=David.Laight@ACULAB.COM \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).