From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B20CA9EB0 for ; Mon, 21 Oct 2019 15:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FD2F2084B for ; Mon, 21 Oct 2019 15:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="de6O542R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729417AbfJUP5E (ORCPT ); Mon, 21 Oct 2019 11:57:04 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:49121 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728205AbfJUP5D (ORCPT ); Mon, 21 Oct 2019 11:57:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571673422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2tFRZlOvIgHzGsOY50Q9X5enGn3XtVTsJKLdNE1jHZY=; b=de6O542R4V3h+eqjWZyjvWqAD5BFV+1EsihCwnRBL0BzodKryGtuN4b+dfIo9CsEZZ54kd tVc96YTgnLbvjJG+o2bisvZ5IpP+GzLkQ3+VdZVgTdSAajR3HvBZtf45OceuHFvL+EjsKY 9idLzKClDIHkoJ0HFO+vC09mXsEKJM0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-yA6bT_4fPyuI5v3UtYsS_A-1; Mon, 21 Oct 2019 11:56:59 -0400 Received: by mail-wr1-f70.google.com with SMTP id v8so6622485wrt.16 for ; Mon, 21 Oct 2019 08:56:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YvFrcyu8DvgIyxxeiblPi76YG2Hq9swys16D2sk2thI=; b=gUYF9CGPopxo3d4wTcLPq+OgD3pIwqNjAYLETe3wlntzLJZS6tjJgESH29bYpxTwEl xNM11Xody1oxSKKpD0iOyF1draD++1L34XLihYs4hfKMOiES73bKC89DxLWPD4fQ1ZZi PrV20V6r9BFhPvcRhlOJvPvR3fAsU2/NcJVhh72CCDCXmmeGBLhhYLHNjx4j1JDS0CCY Filpq9qmyZkBFmqLJk/75otlcPuyWIny1Pe6YKcR//EuEC9QFA3tm0PRJay84clOh3V1 WWur5lEUjSRgMeLZ+F0Rv6PBWupSdy/+vqLA0UE/rbSReds3yob3XEmWZcV3uJcgkrtV 0xFg== X-Gm-Message-State: APjAAAVujgwfmEXbm0xjLPUw8BkCOBMgAjtxWhQZD9BkkjLf3c9Fe++v ykyx0cOnnLbR+UueNdaDkr2xLG9pELC/ismjgtfCsKtAc/IYskAj9TDg1c17z7arhCHl6/agjjm iXkNvaK8QfOf3buFGFbWLZVHqyigp X-Received: by 2002:a05:600c:2201:: with SMTP id z1mr20453574wml.169.1571673418327; Mon, 21 Oct 2019 08:56:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwPfUSXwj2RBQAOL+Bs6XgNsrB/x5EQDokVunT5lvWqBC6nAWQYxZ5p2uqJSVkkUprv7ruuQQ== X-Received: by 2002:a05:600c:2201:: with SMTP id z1mr20453563wml.169.1571673418145; Mon, 21 Oct 2019 08:56:58 -0700 (PDT) Received: from shalem.localdomain (2001-1c00-0c14-2800-ec23-a060-24d5-2453.cable.dynamic.v6.ziggo.nl. [2001:1c00:c14:2800:ec23:a060:24d5:2453]) by smtp.gmail.com with ESMTPSA id v11sm13140430wml.30.2019.10.21.08.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2019 08:56:57 -0700 (PDT) Subject: Re: [PATCH] tpm: Switch to platform_get_irq_optional() To: Jarkko Sakkinen Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, stable@vger.kernel.org References: <20191019094528.27850-1-hdegoede@redhat.com> <20191021154942.GB4525@linux.intel.com> From: Hans de Goede Message-ID: <80409d36-53fa-d159-d864-51b8495dc306@redhat.com> Date: Mon, 21 Oct 2019 17:56:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191021154942.GB4525@linux.intel.com> Content-Language: en-US X-MC-Unique: yA6bT_4fPyuI5v3UtYsS_A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi, On 21-10-2019 17:49, Jarkko Sakkinen wrote: > On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote: >> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message = to >> platform_get_irq*()"), platform_get_irq() will call dev_err() on an erro= r, >> as the IRQ usage in the tpm_tis driver is optional, this is undesirable. >> >> Specifically this leads to this new false-positive error being logged: >> [ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found >> >> This commit switches to platform_get_irq_optional(), which does not log >> an error, fixing this. >> >> Cc: # 5.4.x >=20 > Incorrect format (should be wo '<' and '>'). According to: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html the '<' and '>' should be added when adding a # > Also, not sure why this should be backported to stable kernel anyway. Because false-positive error messages are bad and cause users to file false-positive bug-reports. Regards, Hans