From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
dhowells@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, jmorris@namei.org, serge@hallyn.com,
nramas@linux.microsoft.com, tusharsu@linux.microsoft.com,
zohar@linux.ibm.com, vt@altlinux.org, gilad@benyossef.com,
pvanleeuwen@rambus.com, zhang.jia@linux.alibaba.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v5 2/8] lib/mpi: Extend the MPI library
Date: Mon, 13 Jul 2020 10:17:55 +0800 [thread overview]
Message-ID: <82c805c6-5614-2889-6e2d-840a2eb8373b@linux.alibaba.com> (raw)
In-Reply-To: <20200710131203.wyj33bq2hgkz6pv4@valinor>
On 2020/7/10 21:12, Marcelo Henrique Cerri wrote:
> Hi, Tianjia.
>
> On Thu, Jul 09, 2020 at 04:40:09PM +0800, Tianjia Zhang wrote:
>> Expand the mpi library based on libgcrypt, and the ECC algorithm of
>> mpi based on libgcrypt requires these functions.
>> Some other algorithms will be developed based on mpi ecc, such as SM2.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>> ---
>> include/linux/mpi.h | 88 +++++++++++
>> lib/mpi/Makefile | 5 +
>> lib/mpi/mpi-add.c | 207 +++++++++++++++++++++++++
>> lib/mpi/mpi-bit.c | 251 ++++++++++++++++++++++++++++++
>> lib/mpi/mpi-cmp.c | 46 ++++--
>> lib/mpi/mpi-div.c | 238 +++++++++++++++++++++++++++++
>> lib/mpi/mpi-internal.h | 53 +++++++
>> lib/mpi/mpi-inv.c | 143 ++++++++++++++++++
>> lib/mpi/mpi-mod.c | 155 +++++++++++++++++++
>> lib/mpi/mpi-mul.c | 94 ++++++++++++
>> lib/mpi/mpicoder.c | 336 +++++++++++++++++++++++++++++++++++++++++
>> lib/mpi/mpih-div.c | 294 ++++++++++++++++++++++++++++++++++++
>> lib/mpi/mpih-mul.c | 25 +++
>> lib/mpi/mpiutil.c | 204 +++++++++++++++++++++++++
>> 14 files changed, 2129 insertions(+), 10 deletions(-)
>> create mode 100644 lib/mpi/mpi-add.c
>> create mode 100644 lib/mpi/mpi-div.c
>> create mode 100644 lib/mpi/mpi-inv.c
>> create mode 100644 lib/mpi/mpi-mod.c
>> create mode 100644 lib/mpi/mpi-mul.c
>>
>> diff --git a/lib/mpi/mpi-add.c b/lib/mpi/mpi-add.c
>> new file mode 100644
>> index 000000000000..9afad7832737
>> --- /dev/null
>> +++ b/lib/mpi/mpi-add.c
>> @@ -0,0 +1,207 @@
>> +/* mpi-add.c - MPI functions
>> + * Copyright (C) 1994, 1996, 1998, 2001, 2002,
>> + * 2003 Free Software Foundation, Inc.
>> + *
>> + * This file is part of Libgcrypt.
>> + *
>> + * Note: This code is heavily based on the GNU MP Library.
>> + * Actually it's the same code with only minor changes in the
>> + * way the data is stored; this is to support the abstraction
>> + * of an optional secure memory allocation which may be used
>> + * to avoid revealing of sensitive data due to paging etc.
>> + */
>> +
>> +#include "mpi-internal.h"
>> +
>> +/****************
>> + * Add the unsigned integer V to the mpi-integer U and store the
>> + * result in W. U and V may be the same.
>> + */
>> +void mpi_add_ui(MPI w, MPI u, unsigned long v)
>> +{
>> + mpi_ptr_t wp, up;
>> + mpi_size_t usize, wsize;
>> + int usign, wsign;
>> +
>> + usize = u->nlimbs;
>> + usign = u->sign;
>> + wsign = 0;
>> +
>> + /* If not space for W (and possible carry), increase space. */
>> + wsize = usize + 1;
>> + if (w->alloced < wsize)
>> + mpi_resize(w, wsize);
>
> You are ignoring the mpi_resize() return. I believe these new functions
> need to return an int to indicate errors as mpi_powm() does.
>
Yes, of course. Thanks for pointing it out.
Thanks,
Tianjia
>
>> +
>> + /* These must be after realloc (U may be the same as W). */
>> + up = u->d;
>> + wp = w->d;
>> +
>> + if (!usize) { /* simple */
>> + wp[0] = v;
>> + wsize = v ? 1:0;
>> + } else if (!usign) { /* mpi is not negative */
>> + mpi_limb_t cy;
>> + cy = mpihelp_add_1(wp, up, usize, v);
>> + wp[usize] = cy;
>> + wsize = usize + cy;
>> + } else {
>> + /* The signs are different. Need exact comparison to determine
>> + * which operand to subtract from which.
>> + */
>> + if (usize == 1 && up[0] < v) {
>> + wp[0] = v - up[0];
>> + wsize = 1;
>> + } else {
>> + mpihelp_sub_1(wp, up, usize, v);
>> + /* Size can decrease with at most one limb. */
>> + wsize = usize - (wp[usize-1] == 0);
>> + wsign = 1;
>> + }
>> + }
>> +
>> + w->nlimbs = wsize;
>> + w->sign = wsign;
>> +}
>> +
next prev parent reply other threads:[~2020-07-13 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:40 [PATCH v5 0/8] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 1/8] crypto: sm3 - export crypto_sm3_final function Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 2/8] lib/mpi: Extend the MPI library Tianjia Zhang
2020-07-10 13:12 ` Marcelo Henrique Cerri
2020-07-13 2:17 ` Tianjia Zhang [this message]
2020-07-09 8:40 ` [PATCH v5 3/8] lib/mpi: Introduce ec implementation to " Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 4/8] crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 5/8] crypto: testmgr - support test with different ciphertext per encryption Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 6/8] X.509: support OSCCA certificate parse Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 7/8] X.509: support OSCCA sm2-with-sm3 certificate verification Tianjia Zhang
2020-07-09 8:40 ` [PATCH v5 8/8] integrity: Asymmetric digsig supports SM2-with-SM3 algorithm Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82c805c6-5614-2889-6e2d-840a2eb8373b@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcelo.cerri@canonical.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nramas@linux.microsoft.com \
--cc=pvanleeuwen@rambus.com \
--cc=serge@hallyn.com \
--cc=tusharsu@linux.microsoft.com \
--cc=vt@altlinux.org \
--cc=zhang.jia@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).