From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D8FC11F65 for ; Wed, 30 Jun 2021 13:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10ADE613DB for ; Wed, 30 Jun 2021 13:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234923AbhF3Nj3 (ORCPT ); Wed, 30 Jun 2021 09:39:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46135 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234768AbhF3Nj2 (ORCPT ); Wed, 30 Jun 2021 09:39:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625060219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w8yguUDxBfw15UKKVkkrjmGqLR3ZTwdTN4ztmj49JQ=; b=Ruw+6L0p0RQTYXR03zG2HWyx1Eo8RjKHAhgh+koblRcryIcXuEzKG1pZ0kRbCYLWSU+n5+ pVfJlbkBVIlIqghusuuxYQ5oIMjkALpUBcnwuG3rSSAUT5PGO+S6Ul67WBtx8xm0tV8uP+ czk5Lq3R54a5Jhhef0YIQscr3Eqkry0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-uAnGnOJ5NlWHrRY7MgdatQ-1; Wed, 30 Jun 2021 09:36:58 -0400 X-MC-Unique: uAnGnOJ5NlWHrRY7MgdatQ-1 Received: by mail-ed1-f72.google.com with SMTP id w1-20020aa7da410000b029039533674a84so1185492eds.9 for ; Wed, 30 Jun 2021 06:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6w8yguUDxBfw15UKKVkkrjmGqLR3ZTwdTN4ztmj49JQ=; b=p1ibW88mWksmXJK9y2S6dB2NzHizawSHYYHAgUPT+1jIwZH4m2Ia6b4sMbQpP9i1kL gPCD616ZJWoLJos8UMh19aetAhs6oQ8BCjBePYHpNr3SEaHSuyyjvCOp6znrINvH/leU qAh3i0RCKMTjGCyQDEA1IJtgNCDjJKRNGuNs8pVU8iph8Dj5qwJ0WRKpBG97OdXWO5AR KCd90auRJmHBP+9JuV7G8tXtEmoBqEe2IW3piHwqEaPJwOfCnkARItcdGvSo1ZP3gRaB yg7n+bYXWfOwAkNWL8pWMno6XQuWYkEANSFITUrFvlRNIpdwvYusw91azXuZFZSaUwqb y1xA== X-Gm-Message-State: AOAM5333RX1jMiyjMoNQMPj/ULFq/sQiIKkKOrBLyy2QDGq7QnYwqXUV DKMsrYsOGWH63unyplQ99SC5bWbLWzTYguhuYY2kX8TgCwPaGc6ASpGDVRc3Z0+48foCnklvWEC EoFB9nO9gGbE6IVgdTycqB0bZDzDb X-Received: by 2002:a05:6402:198:: with SMTP id r24mr47400324edv.93.1625060217221; Wed, 30 Jun 2021 06:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydnpGwOmZgVlTMANR5TvgKyDuZoAI6lHYytu9Xe16jyg0rEJwzwm/jqf1PEhCSSoKhZOZ/bg== X-Received: by 2002:a05:6402:198:: with SMTP id r24mr47400296edv.93.1625060217018; Wed, 30 Jun 2021 06:36:57 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id yc11sm3064313ejb.109.2021.06.30.06.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jun 2021 06:36:56 -0700 (PDT) Subject: Re: Recent tpm_tis IRQ handling changes are causing kernel backtraces] From: Hans de Goede To: Jarkko Sakkinen Cc: Jerry Snitselaar , Matthew Garrett , linux-integrity , James Bottomley References: <20210527140025.vl3ply6wnn7rsygg@kernel.org> <27d71b81-1e89-1b5d-ddaf-a8928bac90fd@redhat.com> <20210531043616.u3v25qzkkrik5apq@kernel.org> <89d5b891-97d8-caed-4eb1-6d4d485a2fd1@redhat.com> <5680899e-9040-7641-e6ac-23edd2d988cf@redhat.com> <49bfb4a7-eb3c-77f9-ff8e-b37617a26195@redhat.com> <20210623134054.45gjj2wbgz7jpjmy@kernel.org> <90ed51b4-66d4-fb10-ca8e-d99532028fab@redhat.com> <20210629180445.oind62rsktevm45q@kernel.org> <20210629220516.xm3jvjy7v2uw3fvz@kernel.org> <29e72255-b995-9ffe-f379-5e9e349bee07@redhat.com> Message-ID: <8819200d-e468-7b09-2e08-e44f5f2ed59f@redhat.com> Date: Wed, 30 Jun 2021 15:36:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <29e72255-b995-9ffe-f379-5e9e349bee07@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi, On 6/30/21 2:47 PM, Hans de Goede wrote: > Hi, > > On 6/30/21 12:05 AM, Jarkko Sakkinen wrote: >> On Tue, Jun 29, 2021 at 09:14:39PM +0200, Hans de Goede wrote: >>> Hi, >>> >>> On 6/29/21 8:04 PM, Jarkko Sakkinen wrote: >>>> On Wed, Jun 23, 2021 at 03:54:59PM +0200, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> On 6/23/21 3:40 PM, Jarkko Sakkinen wrote: >>>>>> On Mon, Jun 21, 2021 at 02:04:52PM +0200, Hans de Goede wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 6/14/21 3:33 PM, Hans de Goede wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> On 6/1/21 6:04 PM, Hans de Goede wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> On 5/31/21 6:36 AM, Jarkko Sakkinen wrote: >>>>>>>>>>> Interestingly enough the first backtrace is also happening on a: >>>>>>>>>>> "Dell Inc. XPS 13 9310/0MRT12, BIOS 2.2.0 04/06/2021" >>>>>>>>>>> >>>>>>>>>>> So it seems that at least with 5.12.6 (which has the last 2 fixes) >>>>>>>>>>> all reports are about the XPS 13 9310. I wonder if there is an >>>>>>>>>>> issue with the TPM interrupt line on the XPS 13 9310; I've asked the >>>>>>>>>>> reporters to try adding tpm_tis.interrupts=0 to their kernel commandline. >>>>>>>>>> >>>>>>>>>> This is helpful for sure that these all are happening on matching hardware. >>>>>>>>> >>>>>>>>> So our kernel-backtrace tracking info (ABRT) just recorded a third backtrace >>>>>>>>> with a kernel >= 5.12.6, again on the XPS 13 9310, so now we have 3 variants: >>>>>>>>> >>>>>>>>> 1. Backtrace starting with a call to ima_add_boot_aggregate >>>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1963712 >>>>>>>>> >>>>>>>>> 2. Backtrace starting with a call to tpm_dev_async_work: >>>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1964974 >>>>>>>>> (note this one is not easily reproducible) >>>>>>>>> >>>>>>>>> 3. Backtrace starting with a call to rng_dev_read: >>>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1920510 >>>>>>>>> >>>>>>>>> 3. is the new one. All bugs linked above are public, all 3 backtraces >>>>>>>>> so far have only been reported on the XPS 13 9310 (with kernel >= 5.12.6) >>>>>>>>> and I've asked all the reporters to check if tpm_tis.interrupts=0 helps. >>>>>>>> >>>>>>>> Quick status update, I've got a response from a XPS 13 9310 user in: >>>>>>>> >>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1920510 >>>>>>>> >>>>>>>> Indicating that a. he can reproduce this with the latest >= 5.12.6 kernels; >>>>>>>> and b. it goes away when specifying tpm_tis.interrupts=0 as I expected >>>>>>>> (I expected this because all the bug-reports started when the interrupt >>>>>>>> code got fixed/re-enabled a while ago). >>>>>>> >>>>>>> One more status update. >>>>>>> >>>>>>> - A new 4th variant of the backtrace has been spotted, where the problem hits >>>>>>> when called from probe() -> tpm2_auto_startup -> tpm2_do_selftest, see: >>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1958381 >>>>>>> >>>>>>> - So far all reports with kernel >= 5.12.6 have been on a Dell XPS 13 9310 >>>>>>> models. But the new variant is happening on a Dell XPS 15 9500 and the >>>>>>> backtrace starting at ima_add_boot_aggregate is also being reported on >>>>>>> a Dell XPS 15 9500 (as well as on the XPS 13 9310). >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Hans >>>>>> >>>>>> OK, I'll have to query if I could borrow that laptop from someone. It's >>>>>> fairly common laptop, i.e. might be possible. >>>>> >>>>> In the mean time I've also got a report that this variant of the backtrace: >>>>> >>>>> 1. Backtrace starting with a call to ima_add_boot_aggregate >>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1963712 >>>>> >>>>> Is also still happening with recent 5.12.y kernels on >>>>> Dell Precision 7750 laptops. Both the Precision 7750 and the XPS 9500 use >>>>> 10th gen comet lake processors (i7-10750H), where as the XPS 9310 is using >>>>> an icelake processor. So the common denominator seems to be that they are >>>>> all 2020 Dell laptop models using the latest Intel CPUs. >>>>> >>>>> FYI the complete list of models on which some of the 4 backtrace variants >>>>> are still seen on recent 5.12.y kernels is now: >>>>> >>>>> Dell XPS 13 9310 >>>>> Dell XPS 15 9500 >>>>> Dell Precision 7750 >>>>> >>>>> Regards, >>>>> >>>>> Hans >>>> >>>> Does "tpm_tis.interrupts=0" uniformly workaround the issue? >>> >>> I unfortunately have not gotten much replies to my request to test with >>> tpm_tis.interrupts=0, but for those people who have bothered to test >>> (2 reporters IIRC) using tpm_tis.interrupts=0 does avoid the issue. >> >> So we see this in dmesg as first anything from TPM: >> >> [ 0.904572] tpm_tis STM0125:00: 2.0 TPM (device-id 0x0, rev-id 78) >> >> This means that one command is successfully processed by the TPM, i.e. >> tpm2_probe() in tpm_tis_core_init(). >> >> My first *guess* was that IRQ is given by ACPI, would need ACPI dump to >> confirm (e.g. sudo acpidump > acpi.dump). It cannot be so because otherwise >> this code path would be executed: >> >> if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) { >> dev_err(&chip->dev, FW_BUG >> "TPM interrupt not working, polling instead\n"); >> >> disable_interrupts(chip); >> } >> >> TPM_CHIP_FLAG_IRQ is never set, so you should see this message in dmesg if >> a legit value is given to IRQ by ACPI. We are probably planning re-enable >> IRQ code after these type of issues are fully resolved, but right now you >> should not end up having it enabled (see tpm_tis_send() function). >> >> To put this together "if (irq != -1) {" path in tpm_tis_core_init() is >> never executed. And early in the same function the interrupt hardware is >> *explicitly* disabled. >> >> For me this looks like a hardware bug right now: interrupts stay enabled >> for some reason. >> >> ACPI dump would be useful to verify some of the assumptions in this. > > Ok, I've added a comment to the Fedora bugs for the 4 different backtrace > variants asking for acpidumps for the Dell XPS 13 9310, Dell XPS 15 9500 > and Dell Precision 7750 laptops. 2 XPS 9310 acpidumps have been attached to: https://bugzilla.redhat.com/show_bug.cgi?id=1920510 https://bugzilla.redhat.com/show_bug.cgi?id=1964974 Note the reporter of the first bug mentions that he is no longer having this issue, but we are definitely still getting reports for kernel version > 5.12.6 (which has the last 2 fixes) from XPS 9310 users... Maybe there are different BIOS versions in play ? It might be interesting to compare the 2 acpidumps... Regards, Hans