From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stephen Boyd <swboyd@chromium.org>, Peter Huewe <peterhuewe@gmx.de>
Cc: Andrey Pronin <apronin@chromium.org>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v6 4/4] tpm: tpm_tis_spi: Support cr50 devices
Date: Sat, 07 Sep 2019 20:04:15 +0300 [thread overview]
Message-ID: <8a6f05b76c37968d494fce9e555f9c21cca83003.camel@linux.intel.com> (raw)
In-Reply-To: <5d6e9a38.1c69fb81.ad03c.cb4c@mx.google.com>
On Tue, 2019-09-03 at 09:52 -0700, Stephen Boyd wrote:
> That's fair. I'll put the Kconfig option back. There's still the small
> issue of what to do about the module name. Should I rename the
> tpm_tis_spi.c file to something else so that the module can keep the
> same name? Or was the tpm_tis_spi_mod.ko trick from v5 good enough?
Not sure I understood the question correctly but how I think
this should be deployed is:
- A boolean CONFIG_TCG_TIS_SPI_CR50.
- tpm_tis_spi_cr50.c that gets compiled in as part of tpm_tis_spi
when the config option is selected.
I think this would best follow the conventions that are in place
already. Please tell if I got something wrong or if there is some
bottleneck in this framework but this is anyway what I would prefer
with the knowledge I have...
/Jarkko
next prev parent reply other threads:[~2019-09-07 17:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:41 [PATCH v6 0/4] tpm: Add driver for cr50 Stephen Boyd
2019-08-29 22:41 ` [PATCH v6 1/4] dt-bindings: tpm: document properties " Stephen Boyd
2019-08-29 22:41 ` [PATCH v6 2/4] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-08-29 22:41 ` [PATCH v6 3/4] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-08-29 22:41 ` [PATCH v6 4/4] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-08-30 15:33 ` Heiko Stuebner
2019-08-30 15:40 ` Stephen Boyd
2019-09-02 16:53 ` kbuild test robot
2019-09-02 18:19 ` kbuild test robot
2019-09-03 16:39 ` Jarkko Sakkinen
2019-09-03 16:52 ` Stephen Boyd
2019-09-07 17:04 ` Jarkko Sakkinen [this message]
2019-09-07 17:20 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6f05b76c37968d494fce9e555f9c21cca83003.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).