From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EE3C433E1 for ; Tue, 23 Jun 2020 11:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF17B20768 for ; Tue, 23 Jun 2020 11:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732329AbgFWL1w (ORCPT ); Tue, 23 Jun 2020 07:27:52 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34780 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732189AbgFWL1u (ORCPT ); Tue, 23 Jun 2020 07:27:50 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05NB6EWM032232; Tue, 23 Jun 2020 07:27:45 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 31uds05fvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jun 2020 07:27:45 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05NBQ8ZX015213; Tue, 23 Jun 2020 11:27:44 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma05wdc.us.ibm.com with ESMTP id 31sa38ptxf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jun 2020 11:27:44 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05NBRgYO10617418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jun 2020 11:27:42 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B43586A054; Tue, 23 Jun 2020 11:27:43 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 002E16A047; Tue, 23 Jun 2020 11:27:42 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 23 Jun 2020 11:27:42 +0000 (GMT) Subject: Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields To: Jarkko Sakkinen Cc: "Rafael J. Wysocki" , Stefan Berger , "Rafael J. Wysocki" , linux-integrity@vger.kernel.org, ACPI Devel Maling List , Linux Kernel Mailing List , linux-security-module@vger.kernel.org References: <20200331214949.883781-1-stefanb@linux.vnet.ibm.com> <20200401083729.GD17325@linux.intel.com> <20200402192145.GB10314@linux.intel.com> <20200623005647.GD28795@linux.intel.com> From: Stefan Berger Message-ID: <8d032b3c-650b-b806-3d97-2921341b7f0e@linux.ibm.com> Date: Tue, 23 Jun 2020 07:27:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200623005647.GD28795@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-23_06:2020-06-23,2020-06-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 cotscore=-2147483648 clxscore=1015 mlxscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006230084 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 6/22/20 8:56 PM, Jarkko Sakkinen wrote: > On Fri, Jun 19, 2020 at 11:14:20AM -0400, Stefan Berger wrote: >> On 4/2/20 3:21 PM, Jarkko Sakkinen wrote: >>> On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote: >>>> On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen >>>> wrote: >>>>> On Tue, Mar 31, 2020 at 05:49:49PM -0400, Stefan Berger wrote: >>>>>> From: Stefan Berger >>>>>> >>>>>> Recent extensions of the TPM2 ACPI table added 3 more fields >>>>>> including 12 bytes of start method specific parameters and Log Area >>>>>> Minimum Length (u32) and Log Area Start Address (u64). So, we extend >>>>>> the existing structure with these fields to allow non-UEFI systems >>>>>> to access the TPM2's log. >>>>>> >>>>>> The specification that has the new fields is the following: >>>>>> TCG ACPI Specification >>>>>> Family "1.2" and "2.0" >>>>>> Version 1.2, Revision 8 >>>>>> >>>>>> Adapt all existing table size calculations to use >>>>>> offsetof(struct acpi_table_tpm2, start_method_specific) >>>>>> [where start_method_specific is a newly added field] >>>>>> rather than sizeof(struct acpi_table_tpm2) so that the addition >>>>>> of the new fields does not affect current systems that may not >>>>>> have them. >>>>>> >>>>>> Signed-off-by: Stefan Berger >>>>>> Cc: linux-acpi@vger.kernel.org >>>>> I think I'm cool with this but needs an ack from ACPI maintainer. >>>>> >>>>> Rafael, given that this not an intrusive change in any possible means, >>>>> can I pick this patch and put it to my next pull request? >>>> Yes, please. >>>> >>>> Thanks! >>> Great, thanks Rafael. >>> >>> Reviewed-by: Jarkko Sakkinen >>> >>> Do you mind if I add your ack to the commit? >> >> Any chance to get v4 applied? > You should split the actbl3.h change to a separate patch and add 'Cc:' > tag to Rafael to the commit message. I did this in one patch because it seems like a mistake to extend the structure and not modify the size checks.   Stefan > > /Jarkko