From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nikita Sobolev <Nikita.Sobolev@synopsys.com>,
Shuah Khan <shuah@kernel.org>
Cc: "linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
Tadeusz Struk <tadeusz.struk@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Subject: Re: [PATCH] selftests/tpm: Fix runtime error
Date: Thu, 14 May 2020 03:07:35 +0300 [thread overview]
Message-ID: <90215c3c313a926267abf66dcfa175dd10f6bc5c.camel@linux.intel.com> (raw)
In-Reply-To: <DM6PR12MB26848928AB4CE7B1D5BAC4B3D9A00@DM6PR12MB2684.namprd12.prod.outlook.com>
On Sun, 2020-05-10 at 18:44 +0000, Nikita Sobolev wrote:
> Hi, Jarkko Sakkinen, all!
>
> Thank you for your notes about commit and sorry for not copying the message
> to you!
It's not a biggie, no worries.
> There is definitely unwanted line of code in the commit.
> After deleting that one, introduced changes work fine.
>
> There is a hardcoded usage of /dev/tpm2 in the kernel selftest. And if there
> is no such device - test fails. I believe this is not a behavior, that we
> expect. Test should be skipped in such case, should it? That is what my
> commit makes.
>
> So, after deleting unwanted line of code and making cosmetic changes (new description + deleting
> excess newline character), can commit be submitted again?
>
> You also mentioned reviewed-by nor tested-by tags in your message. Who should make these tags?
>
> P.S.
> Also there was a question: why do I declare exit code with a constant instead of just exit 4.
> I chose this style because it is used in other kernel selftests for such kind of checks.
> It is proper to follow common style rules. Should I argument this decision in commit message?
>
> -Nikita
Yes, you are of course free to submit a new patch for review.
/Jarkko
prev parent reply other threads:[~2020-05-14 0:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:11 [PATCH] selftests/tpm: Fix runtime error Jarkko Sakkinen
2020-04-12 14:18 ` Jarkko Sakkinen
2020-05-10 18:44 ` Nikita Sobolev
2020-05-14 0:07 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90215c3c313a926267abf66dcfa175dd10f6bc5c.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Nikita.Sobolev@synopsys.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=shuah@kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).