From: Chao Yu <yuchao0@huawei.com>
To: Eric Biggers <ebiggers@kernel.org>, <linux-fscrypt@vger.kernel.org>
Cc: <linux-ext4@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-fsdevel@vger.kernel.org>, <linux-api@vger.kernel.org>,
<linux-integrity@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Victor Hsieh <victorhsieh@google.com>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v5 16/16] f2fs: add fs-verity support
Date: Tue, 25 Jun 2019 15:55:57 +0800 [thread overview]
Message-ID: <90495fb1-72eb-ca42-8457-ef8e969eda51@huawei.com> (raw)
In-Reply-To: <20190620205043.64350-17-ebiggers@kernel.org>
Hi Eric,
On 2019/6/21 4:50, Eric Biggers wrote:
> +static int f2fs_begin_enable_verity(struct file *filp)
> +{
> + struct inode *inode = file_inode(filp);
> + int err;
> +
I think we'd better add condition here (under inode lock) to disallow enabling
verity on atomic/volatile inode, as we may fail to write merkle tree data due to
atomic/volatile inode's special writeback method.
> + err = f2fs_convert_inline_inode(inode);
> + if (err)
> + return err;
> +
> + err = dquot_initialize(inode);
> + if (err)
> + return err;
We can get rid of dquot_initialize() here, since f2fs_file_open() ->
dquot_file_open() should has initialized quota entry previously, right?
Thanks,
> +
> + set_inode_flag(inode, FI_VERITY_IN_PROGRESS);
> + return 0;
> +}
> +
next prev parent reply other threads:[~2019-06-25 7:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:50 [PATCH v5 00/16] fs-verity: read-only file-based authenticity protection Eric Biggers
2019-06-20 20:50 ` [PATCH v5 01/16] fs-verity: add a documentation file Eric Biggers
2019-06-22 22:10 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 02/16] fs-verity: add MAINTAINERS file entry Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 03/16] fs-verity: add UAPI header Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 04/16] fs: uapi: define verity bit for FS_IOC_GETFLAGS Eric Biggers
2019-06-22 22:11 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 05/16] fs-verity: add Kconfig and the helper functions for hashing Eric Biggers
2019-06-22 22:17 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 06/16] fs-verity: add inode and superblock fields Eric Biggers
2019-06-22 22:18 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 07/16] fs-verity: add the hook for file ->open() Eric Biggers
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 08/16] fs-verity: add the hook for file ->setattr() Eric Biggers
2019-06-22 22:28 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 09/16] fs-verity: add data verification hooks for ->readpages() Eric Biggers
2019-06-22 22:32 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 10/16] fs-verity: implement FS_IOC_ENABLE_VERITY ioctl Eric Biggers
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 11/16] fs-verity: implement FS_IOC_MEASURE_VERITY ioctl Eric Biggers
2019-06-22 22:43 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 12/16] fs-verity: add SHA-512 support Eric Biggers
2019-06-22 22:44 ` Jaegeuk Kim
2019-06-20 20:50 ` [PATCH v5 13/16] fs-verity: support builtin file signatures Eric Biggers
2019-06-20 20:50 ` [PATCH v5 14/16] ext4: add basic fs-verity support Eric Biggers
2019-06-20 23:59 ` Darrick J. Wong
2019-06-21 3:17 ` Eric Biggers
2019-06-20 20:50 ` [PATCH v5 15/16] ext4: add fs-verity read support Eric Biggers
2019-06-20 20:50 ` [PATCH v5 16/16] f2fs: add fs-verity support Eric Biggers
2019-06-22 23:12 ` Jaegeuk Kim
2019-06-25 7:55 ` Chao Yu [this message]
2019-06-25 17:52 ` Eric Biggers
2019-06-26 7:34 ` Chao Yu
2019-06-26 18:21 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90495fb1-72eb-ca42-8457-ef8e969eda51@huawei.com \
--to=yuchao0@huawei.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=victorhsieh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).