linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roberto Sassu <roberto.sassu@huawei.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>
Cc: Stefan Berger <stefanb@linux.ibm.com>,
	Russell Coker <russell@coker.com.au>
Subject: RE: [RFC PATCH 1/2] ima: differentiate between EVM failures in the audit log
Date: Fri, 4 Jun 2021 06:37:16 +0000	[thread overview]
Message-ID: <9b88066d72c64117a923acafca62db72@huawei.com> (raw)
In-Reply-To: <20210603151819.242247-2-zohar@linux.ibm.com>

> From: Mimi Zohar [mailto:zohar@linux.ibm.com]
> Sent: Thursday, June 3, 2021 5:18 PM
> Differenatiate between an invalid EVM portable signature failure

Typo.

> from other EVM HMAC/signature failures.
> 
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>

Thanks, looks good.

Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>

Roberto

HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Li Jian, Shi Yanli

> ---
>  security/integrity/ima/ima_appraise.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_appraise.c
> b/security/integrity/ima/ima_appraise.c
> index 940695e7b535..ef9dcfce45d4 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -422,7 +422,8 @@ int ima_appraise_measurement(enum ima_hooks
> func,
>  		goto out;
>  	case INTEGRITY_FAIL_IMMUTABLE:
>  		set_bit(IMA_DIGSIG, &iint->atomic_flags);
> -		fallthrough;
> +		cause = "invalid-fail-immutable";
> +		goto out;
>  	case INTEGRITY_FAIL:		/* Invalid HMAC/signature. */
>  		cause = "invalid-HMAC";
>  		goto out;
> --
> 2.27.0


  reply	other threads:[~2021-06-04  6:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 15:18 [RFC PATCH 0/2] EVM: add some debugging info Mimi Zohar
2021-06-03 15:18 ` [RFC PATCH 1/2] ima: differentiate between EVM failures in the audit log Mimi Zohar
2021-06-04  6:37   ` Roberto Sassu [this message]
2021-06-03 15:18 ` [RFC PATCH 2/2] evm: output EVM digest calculation info needed for debugging Mimi Zohar
2021-06-03 16:34   ` nramas
2021-06-03 16:55     ` Mimi Zohar
2021-06-03 17:48       ` nramas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b88066d72c64117a923acafca62db72@huawei.com \
    --to=roberto.sassu@huawei.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=russell@coker.com.au \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).